Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
strip_prefix("0x")/starts_with("0x")calls with canonicalhex_utilshelpers (strip_0x,require_0x) acrosstrace_renderer.rsandselector_resolver.rs.parse_rpc_responseinfetch_chain_idinstead of manual JSON parsing, so HTTP errors (e.g. 502) produce clear status messages instead of misleading "invalid JSON".is_valid_address/is_valid_tx_hashpredicates tohex_utilscovering uppercase0Xprefix and hex digit validation; wire them intocontract_resolver,validate_address, and a newvalidate_tx_hashused bytx.rs.serde_json::Valueindexing with typedDeserializestructs (SelectorEntry,ContractInfo,Compilation) in both sourcify resolvers.Option<String>parameter (explicit > env var > default) for test-friendly dependency injection.SELECTOR_CACHE,CONTRACT_CACHE,ALL_CACHE_KINDS) indisk_cache.rs; remove duplicatedCACHE_KINDSfromclean.rs.CallTracestruct fromcli/trace.rstoutils/trace_renderer.rsto fixutils/→cli/layering violation.