Skip to content

[WIP] Address feedback from review on V3 dev PR#26

Merged
tinsever merged 1 commit intov3-devfrom
copilot/sub-pr-23-another-one
Dec 31, 2025
Merged

[WIP] Address feedback from review on V3 dev PR#26
tinsever merged 1 commit intov3-devfrom
copilot/sub-pr-23-another-one

Conversation

Copy link

Copilot AI commented Dec 31, 2025

Plan to address review feedback

  • Understand current implementation of installAsync and saveAtAsync
  • Modify installAsync to collect errors instead of throwing on first failure
  • Modify saveAtAsync to collect errors instead of throwing on first failure
  • Ensure both functions continue processing remaining fonts after errors
  • Add error information to the return type to report failures
  • Update CLI to handle aggregate errors and display results + failures
  • Test the changes to ensure proper error handling
  • Run code review
  • Run security checks

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI mentioned this pull request Dec 31, 2025
@tinsever tinsever marked this pull request as ready for review December 31, 2025 23:41
@tinsever tinsever merged commit 7d40513 into v3-dev Dec 31, 2025
1 check failed
Copilot AI requested a review from tinsever December 31, 2025 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants