Skip to content

Fix tc358743 identifier in the /boot/config.txt population#1617

Merged
mtlynch merged 2 commits into
masterfrom
fix-tc358743-audio
Sep 1, 2023
Merged

Fix tc358743 identifier in the /boot/config.txt population#1617
mtlynch merged 2 commits into
masterfrom
fix-tc358743-audio

Conversation

@mtlynch
Copy link
Copy Markdown
Contributor

@mtlynch mtlynch commented Sep 1, 2023

This fixes a small bug in the tinypilot.postinst that was preventing it from matching the right line in /boot/config.txt to add the dtoverlay=tc358743-audio line.

Peer testing

To test this bundle run:

curl \
  --silent \
  --show-error \
  --location \
  https://raw.githubusercontent.com/tiny-pilot/tinypilot/master/scripts/install-bundle | \
  sudo bash -s -- \
    https://output.circle-artifacts.com/output/job/0bcd7da3-9a88-4126-ada8-6a7804e02dfe/artifacts/0/bundler/dist/tinypilot-community-20230901T1500Z-1.9.0-75+03827f4.tgz && \
  sudo reboot

Review on CodeApprove

This fixes a small bug in the tinypilot.postinst that was preventing it from matching the right line in /boot/config.txt to add the 'dtoverlay=tc358743-audio' line.
@mtlynch mtlynch marked this pull request as ready for review September 1, 2023 15:15
@mtlynch mtlynch requested a review from db39 September 1, 2023 15:15
Copy link
Copy Markdown
Contributor Author

mtlynch commented Sep 1, 2023

Automated comment from CodeApprove ➜

@db39 please review this Pull Request

@mtlynch
Copy link
Copy Markdown
Contributor Author

mtlynch commented Sep 1, 2023

@db39 - Can you try the peer test on a bare Raspbian system with TC358743 enabled and make sure you hear audio? I'm getting inconsistent results with audio, but I still see the issue on 2.6.0, so I can't figure out if there's something off in my environment, or if there's something we've introduced in 2.6.1.

@mtlynch
Copy link
Copy Markdown
Contributor Author

mtlynch commented Sep 1, 2023

@db39 - Sorry to rush, but this one is a high priority, as I'm aiming to cut a release candidate by EOD.

@db39
Copy link
Copy Markdown
Contributor

db39 commented Sep 1, 2023

@mtlynch - No worries - starting testing now.

@db39
Copy link
Copy Markdown
Contributor

db39 commented Sep 1, 2023

Audio worked fine in my testing (bare Raspian Bullseye 32-bit).

Copy link
Copy Markdown
Contributor

@db39 db39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated comment from CodeApprove ➜

Approved on CodeApprove
✔️ Approved

LGTM!


👀 @mtlynch it's your turn please take a look

@mtlynch
Copy link
Copy Markdown
Contributor Author

mtlynch commented Sep 1, 2023

Great, thanks!

@mtlynch mtlynch merged commit a7cc8d0 into master Sep 1, 2023
@mtlynch mtlynch deleted the fix-tc358743-audio branch September 1, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants