Fix tc358743 identifier in the /boot/config.txt population#1617
Merged
Conversation
This fixes a small bug in the tinypilot.postinst that was preventing it from matching the right line in /boot/config.txt to add the 'dtoverlay=tc358743-audio' line.
Contributor
Author
Automated comment from CodeApprove ➜⏳ @db39 please review this Pull Request |
Contributor
Author
|
@db39 - Can you try the peer test on a bare Raspbian system with TC358743 enabled and make sure you hear audio? I'm getting inconsistent results with audio, but I still see the issue on 2.6.0, so I can't figure out if there's something off in my environment, or if there's something we've introduced in 2.6.1. |
Contributor
Author
|
@db39 - Sorry to rush, but this one is a high priority, as I'm aiming to cut a release candidate by EOD. |
Contributor
|
@mtlynch - No worries - starting testing now. |
Contributor
|
Audio worked fine in my testing (bare Raspian Bullseye 32-bit). |
db39
approved these changes
Sep 1, 2023
Contributor
Author
|
Great, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This fixes a small bug in the tinypilot.postinst that was preventing it from matching the right line in
/boot/config.txtto add thedtoverlay=tc358743-audioline.Peer testing
To test this bundle run: