Skip to content

Fix FORCE_INSTALL when using simple install commands#1865

Merged
db39 merged 1 commit into
masterfrom
1864-force_install-doesnt-work-as-expected
Jan 17, 2025
Merged

Fix FORCE_INSTALL when using simple install commands#1865
db39 merged 1 commit into
masterfrom
1864-force_install-doesnt-work-as-expected

Conversation

@db39
Copy link
Copy Markdown
Contributor

@db39 db39 commented Jan 16, 2025

Resolves #1864

This change updates get-install.sh to preserve the FORCE_INSTALL environment variable when running sudo ./install.

This allows users to set FORCE_INSTALL before running the simple install commands.

To test live on a device, install Raspberry Pi OS Bullseye 32-bit and run:

export FORCE_INSTALL=1

And then:

curl \
  --silent \
  --show-error \
  https://raw.githubusercontent.com/tiny-pilot/tinypilot/refs/heads/1864-force_install-doesnt-work-as-expected/get-tinypilot.sh | \
    bash - && \
  sudo reboot

Review on CodeApprove

@db39 db39 linked an issue Jan 16, 2025 that may be closed by this pull request
@db39 db39 requested a review from cghague January 16, 2025 12:10
Copy link
Copy Markdown
Contributor Author

db39 commented Jan 16, 2025

Automated comment from CodeApprove ➜

@cghague please review this Pull Request

Copy link
Copy Markdown
Contributor

@cghague cghague left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated comment from CodeApprove ➜

Approved on CodeApprove
✔️ Approved

LGTM


👀 @db39 it's your turn please take a look

@db39 db39 merged commit 3921b8e into master Jan 17, 2025
@db39 db39 deleted the 1864-force_install-doesnt-work-as-expected branch January 17, 2025 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FORCE_INSTALL doesn't work as expected

2 participants