Provide a more flexible script for administrative management of audits

Summary: Fixes T3679. This comes up every so often and the old script is extremely broad (nuke everything in a repository). Provide a more surgical tool.

Test Plan: Ran a bunch of variations of the script and they all seemed to work OK.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran, staticshock

Maniphest Tasks: T3679

Differential Revision: https://secure.phabricator.com/D6678

Author: epriestley

bin/audit

@@ -0,0 +1 @@
+../scripts/setup/manage_audit.php

scripts/repository/audit.php

@@ -1,83 +1,5 @@
 #!/usr/bin/env php
 <?php
 
-$root = dirname(dirname(dirname(__FILE__)));
-require_once $root.'/scripts/__init_script__.php';
-
-$args = new PhutilArgumentParser($argv);
-$args->setTagline('manage open Audit requests');
-$args->setSynopsis(<<<EOSYNOPSIS
-**audit.php** __repository_callsign__
-    Close all open audit requests in a repository. This is intended to
-    reset the state of an imported repository which triggered a bunch of
-    spurious audit requests during import.
-
-EOSYNOPSIS
-  );
-$args->parseStandardArguments();
-$args->parse(
-  array(
-    array(
-      'name'      => 'more',
-      'wildcard'  => true,
-    ),
-  ));
-
-$more = $args->getArg('more');
-if (count($more) !== 1) {
-  $args->printHelpAndExit();
-}
-$callsign = reset($more);
-
-$repository = id(new PhabricatorRepository())->loadOneWhere(
-  'callsign = %s',
-  $callsign);
-if (!$repository) {
-  throw new Exception("No repository exists with callsign '{$callsign}'!");
-}
-
-$ok = phutil_console_confirm(
-  'This will reset all open audit requests ("Audit Required" or "Concern '.
-  'Raised") for commits in this repository to "Audit Not Required". This '.
-  'operation destroys information and can not be undone! Are you sure '.
-  'you want to proceed?');
-if (!$ok) {
-  echo "OK, aborting.\n";
-  die(1);
-}
-
-echo "Loading commits...\n";
-$all_commits = id(new PhabricatorRepositoryCommit())->loadAllWhere(
-  'repositoryID = %d',
-  $repository->getID());
-
-echo "Clearing audit requests...\n";
-
-foreach ($all_commits as $commit) {
-  $query = id(new PhabricatorAuditQuery())
-    ->withStatus(PhabricatorAuditQuery::STATUS_OPEN)
-    ->withCommitPHIDs(array($commit->getPHID()));
-  $requests = $query->execute();
-
-  echo "Clearing ".$commit->getPHID()."... ";
-
-  if (!$requests) {
-    echo "nothing to do.\n";
-    continue;
-  } else {
-    echo count($requests)." requests to clear";
-  }
-
-  foreach ($requests as $request) {
-    $request->setAuditStatus(
-      PhabricatorAuditStatusConstants::AUDIT_NOT_REQUIRED);
-    $request->save();
-    echo ".";
-  }
-
-  $commit->setAuditStatus(PhabricatorAuditCommitStatusConstants::NONE);
-  $commit->save();
-  echo "\n";
-}
-
-echo "Done.\n";
+echo "This script has been replaced with `bin/audit`.\n";
+exit(1);

scripts/setup/manage_audit.php

@@ -0,0 +1,22 @@
+#!/usr/bin/env php
+<?php
+
+$root = dirname(dirname(dirname(__FILE__)));
+require_once $root.'/scripts/__init_script__.php';
+
+$args = new PhutilArgumentParser($argv);
+$args->setTagline('manage audits');
+$args->setSynopsis(<<<EOSYNOPSIS
+**audit** __command__ [__options__]
+    Manage Phabricator audits.
+
+EOSYNOPSIS
+  );
+$args->parseStandardArguments();
+
+$workflows = array(
+  new PhabricatorAuditManagementDeleteWorkflow(),
+  new PhutilHelpArgumentWorkflow(),
+);
+
+$args->parseWorkflows($workflows);

src/__phutil_library_map__.php

@@ -862,6 +862,8 @@
     'PhabricatorAuditListController' => 'applications/audit/controller/PhabricatorAuditListController.php',
     'PhabricatorAuditListView' => 'applications/audit/view/PhabricatorAuditListView.php',
     'PhabricatorAuditMailReceiver' => 'applications/audit/mail/PhabricatorAuditMailReceiver.php',
+    'PhabricatorAuditManagementDeleteWorkflow' => 'applications/audit/management/PhabricatorAuditManagementDeleteWorkflow.php',
+    'PhabricatorAuditManagementWorkflow' => 'applications/audit/management/PhabricatorAuditManagementWorkflow.php',
     'PhabricatorAuditPreviewController' => 'applications/audit/controller/PhabricatorAuditPreviewController.php',
     'PhabricatorAuditQuery' => 'applications/audit/query/PhabricatorAuditQuery.php',
     'PhabricatorAuditReplyHandler' => 'applications/audit/mail/PhabricatorAuditReplyHandler.php',
@@ -2884,6 +2886,8 @@
     'PhabricatorAuditListController' => 'PhabricatorAuditController',
     'PhabricatorAuditListView' => 'AphrontView',
     'PhabricatorAuditMailReceiver' => 'PhabricatorObjectMailReceiver',
+    'PhabricatorAuditManagementDeleteWorkflow' => 'PhabricatorAuditManagementWorkflow',
+    'PhabricatorAuditManagementWorkflow' => 'PhutilArgumentWorkflow',
     'PhabricatorAuditPreviewController' => 'PhabricatorAuditController',
     'PhabricatorAuditReplyHandler' => 'PhabricatorMailReplyHandler',
     'PhabricatorAuthAccountView' => 'AphrontView',