refactor: use tinyauthapp/paerser instead of traefik/paerser#781
refactor: use tinyauthapp/paerser instead of traefik/paerser#781steveiliop56 merged 2 commits intomainfrom
Conversation
📝 WalkthroughWalkthroughThis PR removes the local Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Documentation Updates 1 document(s) were updated by changes in this PR: contributingView Changes@@ -20,23 +20,6 @@
```sh
git clone https://github.com/steveiliop56/tinyauth
cd tinyauth
-```
-
-## Initialize Submodules
-
-The project uses Git submodules for some dependencies, so you need to initialize them with:
-
-```sh
-git submodule init
-git submodule update
-```
-
-## Apply patches
-
-Some of the dependencies must be patched in order to work correctly with the project, you can apply the patches by running:
-
-```sh
-git apply --directory paerser/ patches/nested_maps.diff
```
## Installing Requirements |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #781 +/- ##
=======================================
Coverage 19.82% 19.82%
=======================================
Files 50 50
Lines 3960 3960
=======================================
Hits 785 785
Misses 3104 3104
Partials 71 71 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
.github/workflows/ci.yml (1)
23-24: Addgo mod verifyto verify module cache integrity.Line 24 downloads modules but does not verify module cache integrity. Adding
go mod verifyis a cheap hardening step for supply-chain safety in CI.Proposed workflow tweak
- - name: Go dependencies - run: go mod download + - name: Go dependencies + run: | + go mod download + go mod verify🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/ci.yml around lines 23 - 24, Add a verification step after the "Go dependencies" step to run `go mod verify` so the CI checks module cache integrity; modify the "Go dependencies" job step (the step named "Go dependencies" that currently runs `go mod download`) to also execute `go mod verify` (either by chaining commands in the same run or adding a follow-up step) so module checks occur after download.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@go.mod`:
- Line 19: The repo is missing regression tests that ensure EnvLoader.Load and
FlagLoader.Load handle nested-map configurations after switching to the
tinyauthapp/paerser fork; add tests analogous to TestDecodeLabels that exercise
env and flag decoding with nested maps to loader_env_test.go and
loader_flag_test.go, respectively. Create table-driven tests that set
environment variables and command-line flags representing nested keys, call
EnvLoader.Load(...) and FlagLoader.Load(...), then assert the resulting
map/struct contains the expected nested entries (use the same sample nested
structure used in TestDecodeLabels for parity) and include failure messages;
reference EnvLoader.Load, FlagLoader.Load, and TestDecodeLabels when
implementing these tests so they mirror the existing decoding expectations and
will catch regressions in the forked parser.
---
Nitpick comments:
In @.github/workflows/ci.yml:
- Around line 23-24: Add a verification step after the "Go dependencies" step to
run `go mod verify` so the CI checks module cache integrity; modify the "Go
dependencies" job step (the step named "Go dependencies" that currently runs `go
mod download`) to also execute `go mod verify` (either by chaining commands in
the same run or adding a follow-up step) so module checks occur after download.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 380f5f88-4fa2-4b0d-b78d-2a474e4d4255
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (22)
.github/workflows/ci.yml.github/workflows/nightly.yml.github/workflows/release.yml.gitmodulesCONTRIBUTING.mdDockerfileDockerfile.devDockerfile.distrolesscmd/tinyauth/create_oidc_client.gocmd/tinyauth/create_user.gocmd/tinyauth/generate_totp.gocmd/tinyauth/healthcheck.gocmd/tinyauth/tinyauth.gocmd/tinyauth/verify_user.gocmd/tinyauth/version.gogo.modinternal/utils/decoders/label_decoder.gointernal/utils/loaders/loader_env.gointernal/utils/loaders/loader_file.gointernal/utils/loaders/loader_flag.gopaerserpatches/nested_maps.diff
💤 Files with no reviewable changes (8)
- .gitmodules
- Dockerfile
- Dockerfile.distroless
- .github/workflows/release.yml
- Dockerfile.dev
- paerser
- .github/workflows/nightly.yml
- patches/nested_maps.diff
Summary by CodeRabbit