Skip to content

Conversation

@alrocar
Copy link
Member

@alrocar alrocar commented Oct 23, 2023

Closes #22

  • CI_MERGE_REQUEST_IID cannot be used as part of the Environment name, since it's only provided in MR creation, so wen merging / closing there's no reference to it.
  • Using CI_COMMIT_AUTHOR which might be available at merge time.
  • This requires the clean up rule to update to run when the MR is merged.
- &cli_telemetry_cleanup_rule
    if: $CI_COMMIT_BRANCH == $CI_DEFAULT_BRANCH
  • I haven't found an easy way to run a pipeline in GitLab on MR close, so environments won't be deleted when a MR is closed yet.

This has the problem an author can only have a single environment for all their PRs

@alrocar alrocar self-assigned this Oct 23, 2023
@alrocar alrocar requested a review from jlmadurga October 24, 2023 06:34
@jlmadurga
Copy link
Collaborator

This has the problem an author can only have a single environment for all their PRs

Should we have an issue pointing this matter? Just in case we have more time for research

@alrocar
Copy link
Member Author

alrocar commented Oct 24, 2023

This has the problem an author can only have a single environment for all their PRs

Should we have an issue pointing this matter? Just in case we have more time for research

I'm creating an issue in this repo when we merge this

@alrocar alrocar merged commit 56c0c7f into main Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci_clean on merge does not work in GitLab

3 participants