ci: upload Playwright artifacts on E2E failure#10
Closed
nathanstitt wants to merge 1 commit into
Closed
Conversation
Mirrors the canonical pattern in tinycld/text. Without this, Playwright's trace.zip, screenshot, video, and error-context.md are written to the runner's filesystem on test failure but evaporate when the runner shuts down — making CI-only flakes hard to diagnose without re-running. `if: failure()` skips the upload on green runs. 14-day retention. Bootstrap template gets the same change in tinycld/bootstrap#3 so future packages inherit it.
Contributor
Author
|
Closing as superseded — the artifact-upload commit is now on top of fix/ci-bootstrap-flag in #8 so both fixes ship together. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Playwright artifact upload on E2E failure, mirroring the canonical pattern already in tinycld/text. Without this, when E2E fails on CI the trace/screenshot/video/error-context files Playwright produces are lost when the runner shuts down — making CI-only flakes hard to debug.
if: failure()skips the upload on green runs to save bandwidth + retention. 14-day retention matches text.Triggered by a CI-only flake in tinycld/mail#3 (5 E2E tests failed on CI but couldn't be reproduced locally even with 15 reps across the same tests at CI's worker count). Without artifacts there was no way to see what the page looked like at the moment of failure.
Test plan
gh run download <run-id> --repo tinycld/<repo>for 14 daysRelated