ci: upload Playwright artifacts on E2E failure#3
Merged
Conversation
Mirrors the canonical pattern in the bootstrap template and every other feature repo (mail, calc, calendar, drive, text). contacts was the only feature repo without this step — likely a pre-existing oversight that the recent bootstrap-flag fix swept past. `if: failure()` skips the upload on green runs. 14-day retention. Future packages get this for free via the bootstrap template's ci.yml (updated in tinycld/bootstrap#3, already merged).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the missing artifact-upload step to contacts' E2E job. Mirrors the canonical pattern in the bootstrap template and every other feature repo (mail, calc, calendar, drive, text). contacts was the only repo without this step — an oversight surfaced by a workflow audit.
if: failure()skips the upload on green runs. 14-day retention.Related