TF-1666 Update debug_agentql_script examples#36
Merged
frankfeng98 merged 7 commits intomainfrom Aug 14, 2024
Merged
Conversation
nearestnabors
suggested changes
Aug 12, 2024
Contributor
There was a problem hiding this comment.
Use https://scrapeme.live/shop for examples instead of google (no GDPR modal breaking the script) and search on "fish".
Also, what's this about? Is this example using smartLocator already?
Contributor
Author
I don't think this example was using Smart Locator before this PR. But this line contains a buggy code that will crash the script (i.e. |
nearestnabors
approved these changes
Aug 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates examples under
debug_agentql_scriptfolder. It updates both async and sync examples by changing to Smart Locators API and adjusting how context managers were created at the start of the script.