DHTXX driver #235
Merged
DHTXX driver #235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add dht package that implements driver for dht thermometer
Add high and low frequency definition of counter Change all code to use counter instead of fixed type uint16
Add device class that performs update of the data if specified Add additional error outputs Add UpdatePolicy struct Add constructor with default and update settings
Add exported error type and error constants for more efficient handling Make unmanaged device struct to implement Device interface
Make Measurements function for dummy device no longer read measurements Now the function just returns stored measurements
Add configure function to managed device
Fix initialization flag for ReadMeasurements in dummy device
Add import comment Exclude DHT from the test package
Member
|
Hello @pleomaxx3002 thank you for this contribution. Could you please add an example under the Thanks! |
Add smoke test for dht driver
Member
|
Thanks for the example @pleomaxx3002 one last change I'd would like to ask can you please eliminate the camel case file names and rename them to all lower case? Thank you very much. |
Member
|
Thank you for making all of the requested updates on this driver @pleomaxx3002 now squash/merging. Thanks again! |
deadprogram
pushed a commit
that referenced
this pull request
Mar 26, 2021
dhtXX: add new driver for dht thermometer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of DHTXX driver based on AdaFruit's driver. #117
Tested with DHT11 and AdaFruit feather-m0