Skip to content

add support extended id for mcp2515#857

Merged
deadprogram merged 3 commits intotinygo-org:devfrom
nobonobo:add-mcp2515-extid
Apr 20, 2026
Merged

add support extended id for mcp2515#857
deadprogram merged 3 commits intotinygo-org:devfrom
nobonobo:add-mcp2515-extid

Conversation

@nobonobo
Copy link
Copy Markdown
Contributor

  • add support extended-id frame for mcp2515
  • remove depends legacy and pin
  • add and use defined errors

nobonobo added a commit to SWITCHSCIENCE/picossci-ffb-wheel that referenced this pull request Apr 16, 2026
@deadprogram
Copy link
Copy Markdown
Member

Hello @nobonobo thank you for the PR.

However, I think it was not correct to replace the pin implementation with machine.Pin. We have been attempting to remove direct dependencies on the machine package, please see #795 for more info.

@nobonobo
Copy link
Copy Markdown
Contributor Author

Understood. I'll restore the machine.Pin dependency later!

@deadprogram
Copy link
Copy Markdown
Member

Understood. I'll restore the machine.Pin dependency later!

Why is it that you need machine.Pin here? It should no longer be required for use.

@nobonobo
Copy link
Copy Markdown
Contributor Author

It was "remove," not "restore."
dependency on "machine.Pin" was removed.

@deadprogram
Copy link
Copy Markdown
Member

Thanks you very much for the improvement @nobonobo now squash/merging.

@deadprogram deadprogram merged commit 1c10dea into tinygo-org:dev Apr 20, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants