chore: update all stubs to esp-flasher-stub v0.5.1#23
chore: update all stubs to esp-flasher-stub v0.5.1#23deadprogram merged 1 commit intotinygo-org:mainfrom
Conversation
|
@jgangemi according to https://github.com/espressif/esp-flasher-stub/blob/master/README.md:
I just wonder if we should wait for the release? Alternately we could switch over entirely, which would mean that this PR should include the updated JSON for all of the currently supported processors. What do you think? |
|
i'm going to defer to you on that. i don't have other hardware to test with. i can say this (and the other PRs, some of which were merged) work pretty reliably on the fork branch i've been pointing my projects at, although there still may be a few edge cases. |
|
Well, I would rather have a PR that switched all of them, if you please. I have several different processors/boards to test with. |
jgangemi
force-pushed
the
jae/upstream-s3-stub
branch
from
0f4ab53 to
12edf04
Compare
|
ok - i'll stick claude on it. 😺 |
jgangemi
force-pushed
the
jae/upstream-s3-stub
branch
2 times, most recently
from
647614e to
fbc528d
Compare
|
done |
|
@jgangemi also please remove Claude as co-comitter, as per my previous comment. Thanks! |
jgangemi
force-pushed
the
jae/upstream-s3-stub
branch
2 times, most recently
from
2d4d187 to
c588565
Compare
jgangemi
changed the title
|
@jgangemi can you please rebase this and resolve merge conflict? Thanks! |
- replace all 9 vendored stubs with upstream release artifacts - add tools/update-stubs.sh for automated stub updates via go generate - add go:generate directive to stub.go - add development docs to README - fix golangci-lint warnings
jgangemi
force-pushed
the
jae/upstream-s3-stub
branch
from
c588565 to
c623eb7
Compare
|
Thanks for the update @jgangemi now merging. |
2 participants
Summary
tools/update-stubs.shfor automated stub downloads viago generateTest plan
go test -v ./pkg/espflasher/...— all stubs load correctly, all tests passgolangci-lint run ./...— zero issues