net: implement ResolveIPAddr with stub for lookupProtocol, take #2 #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o-org#2 This is a rework of PR#24 based on review comments. The rework mostly involved moving changes to the proper files, aligning with upstream Go src/net file layout.
Contributor
|
Lgtm 👍 |
Member
|
Thanks for the addition @paralin and to @scottfeldman for bringing it back to life. Now merging. |
Member
|
@scottfeldman and @paralin looks like a small problem with Windows and this PR. Please see error here https://github.com/tinygo-org/tinygo/actions/runs/12651738880/job/35253726771?pr=4684#step:7:13 |
Contributor
|
@scottfeldman it looks like lookupProtocol needs to be implemented for the windows build tag. |
scottfeldman
added a commit
to scottfeldman/tinygo-net
that referenced
this pull request
Jan 19, 2025
This fixes a problem with tinygo-org#36 which causes the Windows TinyGO build to fail. The problem is the function lookupProtocol was missing for Windows build. This PR adds the function for Windows. I can't really test this because I don't have a Windows system, but by inspection is seems like it's correct.
deadprogram
pushed a commit
that referenced
this pull request
Feb 17, 2025
This fixes a problem with #36 which causes the Windows TinyGO build to fail. The problem is the function lookupProtocol was missing for Windows build. This PR adds the function for Windows. I can't really test this because I don't have a Windows system, but by inspection is seems like it's correct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @paralin, I hope you don't mind me resurrecting PR#24.
This is a rework of PR#24 based on review comments. The rework mostly involved moving changes to the proper files, aligning with upstream Go src/net file layout.
I tested this PR on examples/net examples. No issues, but those tests don't hit the newly added changes, so not expecting any issues. Code changes by inspection LGTM.
If this PR is merged, PR#24 can be closed.