Skip to content

Conversation

@suda
Copy link
Contributor

@suda suda commented Feb 17, 2020

This PR adds Particle Argon, Boron and Xenon boards to the docs.

It's blocked by tinygo-org/tinygo#904 after which is merged, we can run make doc-gen to generate machine package docs for those boards.

@deadprogram deadprogram changed the base branch from master to dev February 18, 2020 14:54
@deadprogram
Copy link
Member

Switched to dev branch so it gets picked up next release.

@conejoninja
Copy link
Member

tinygo-org/tinygo#904 was merged, is anything besides the make doc-gen stopping this to be merged too?

@suda
Copy link
Contributor Author

suda commented Feb 25, 2020

No, only make doc-gen is blocking. It's sill failing on particle-argon and I assumed it's because the tinygo-org/tinygo#904 got merged into dev branch and doc-gen expects master. Is there a way to force generating docs from the dev branch?

@aykevl
Copy link
Member

aykevl commented Feb 25, 2020

Is there a way to force generating docs from the dev branch?

If you have the dev version of TinyGo installed (go install) it should just work.

@suda
Copy link
Contributor Author

suda commented Feb 25, 2020

Oh installing made it run! It's just generating an empty file, i.e.:

---
title: particle-argon
---

It actually resets all files in content/microcontrollers/machine. Anything else I might be missing?

@aykevl
Copy link
Member

aykevl commented Feb 26, 2020

I'm not sure what goes on there, it works for me (and includes the Particle boards).

@suda suda force-pushed the feature/particle-boards branch from ffde796 to 249c200 Compare February 27, 2020 20:10
@suda
Copy link
Contributor Author

suda commented Feb 27, 2020

Ok, I got it working! Ready for review 😊

@deadprogram
Copy link
Member

Now merging, thanks @suda

@deadprogram deadprogram merged commit 8f1c552 into tinygo-org:dev Apr 12, 2020
@suda suda deleted the feature/particle-boards branch April 13, 2020 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants