sam: fix register access for interrupts pins in samd51 #1141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deadprogram
reviewed
May 30, 2020
src/machine/machine_atsamd51.go
Outdated
| interruptPins[extint] = p | ||
|
|
||
| if (sam.EIC.CTRLA.Get() & 0x02) == 0 { | ||
| if (sam.EIC.CTRLA.Get() & sam.EIC_CTRLA_ENABLE) == 0 { |
Member
There was a problem hiding this comment.
You could use the volatile package HasBits() function here:
if !sam.EIC.CTRLA.HasBits(sam.EIC_CTRLA_ENABLE) {
Member
Author
There was a problem hiding this comment.
The source code has been modified.
It's better to use HasBits().
Member
Author
|
I tested it with feather-m4 and confirmed that it works. |
Member
|
Squashed and merged, thank you @sago35 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1139
@deadprogram
This PR modifies the register access for interrupts pins on samd51.
Since only the EIC.CTRLA.ENABLE bit is required, only the EIC.CTRLA.ENABLE bit should be accessed and changed.
I tested it with feather-m4 and confirmed that it works.