Skip to content

sam: fix register access for interrupts pins in samd51 #1141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 30, 2020
Merged

sam: fix register access for interrupts pins in samd51 #1141

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd707c4
sam: fix register access for interrupts pins in samd51
sago35 May 29, 2020
c9b3763
use HasBits()
sago35 May 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/machine/machine_atsamd51.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,7 +335,7 @@ func (p Pin) SetInterrupt(change PinChange, callback func(Pin)) error {
pinCallbacks[extint] = callback
interruptPins[extint] = p

if (sam.EIC.CTRLA.Get() & 0x02) == 0 {
if !sam.EIC.CTRLA.HasBits(sam.EIC_CTRLA_ENABLE) {
// EIC peripheral has not yet been initialized. Initialize it now.

// The EIC needs two clocks: CLK_EIC_APB and GCLK_EIC. CLK_EIC_APB is
Expand All @@ -349,7 +349,7 @@ func (p Pin) SetInterrupt(change PinChange, callback func(Pin)) error {
}

// CONFIG register is enable-protected, so disable EIC.
sam.EIC.CTRLA.Set(0)
sam.EIC.CTRLA.ClearBits(sam.EIC_CTRLA_ENABLE)

// Configure this pin. Set the 4 bits of the EIC.CONFIGx register to the
// sense value (filter bit set to 0, sense bits set to the change value).
Expand Down