testing: implement dummy Helper method #1411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lets a few more packages pass tests: container/heap and encoding/ascii85.
Member
Author
|
The one failure appears to be unrelated to the code changes. |
Member
|
Passed TinyHCI after restart.
Yes. That is exactly what we want. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets a few more packages pass tests: container/heap and encoding/ascii85.
After putting a lot of work in getting the standard library test package to work, I'm not sure whether that's the way forward. It consumes a lot RAM, which is often limited on microcontrollers (for example, it appears to run each test in a separate goroutine). And ideally we'd run tests directly on microcontrollers too. That's why I now plan to improve the testing package so that it is more compatible with the upstream testing package and get more packages to pass tests that way.