testing: implement some benchmark stubs #1412
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aykevl
force-pushed
the
test-benchmark-stubs
branch
from
e189bb5 to
7883712
Compare
Member
Author
|
Removed crypto/rc4 as it doesn't work on Go 1.11. |
This allows the following packages to pass tests: * crypto/des * encoding/hex I have not included crypto/rc4 as it doesn't pass tests on Go 1.11 (but it works on later versions).
aykevl
force-pushed
the
test-benchmark-stubs
branch
from
7883712 to
8d82e59
Compare
Member
Author
|
Rebased, after a conflict with #1411 |
Member
|
Looking good, now merging. Thanks @aykevl |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the following packages to pass tests:
crypto/rc4... which are two outdated ciphers and one potentially useful package. Still, it's a good thing to get as many packages to pass tests, if nothing else it helps to catch regressions in the compiler.