reflect: Select constants and stubs
#3425
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgryski
requested changes
Feb 2, 2023
Member
dgryski
left a comment
dgryski
left a comment
There was a problem hiding this comment.
These should probably be in value.go with everything else. I just put them in chan.go for convenience when I was trying to get the lua stuff to build.
aykevl
reviewed
Feb 10, 2023
Member
aykevl
left a comment
aykevl
left a comment
There was a problem hiding this comment.
These should probably be in
value.gowith everything else.
Agreed, plus two really minor nits you can fix at the same time. Other than that, this looks good to me.
|
|
||
| func (v Value) Send(x Value) { | ||
| panic("reflect.Value.Send(): unimplemented") | ||
|
|
|
|
||
| func (v Value) Close() { | ||
| panic("reflect.Value.Close(): unimplemented") | ||
|
|
Member
|
Incorporated this change into #3470 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds constants and stubs to
reflectpackage to support compilation mentioned in #742 (comment)