Skip to content

Uses `go version' and zversion.go to detect version, fixes #433 #435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Uses `go version' and zversion.go to detect version, fixes #433 #435

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e302b7b
Uses `go version' and zversion.go to detect version, fixes #433
Jul 4, 2019
7b7285f
Restored old $GOROOT/VERSION behavior
Jul 4, 2019
5fed8d6
Fixed error handling
Jul 4, 2019
2605b10
Fixed err return
Jul 4, 2019
60dc5d9
Removed `go version' check
diamondburned Jul 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 21 additions & 4 deletions target.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import (
"os/exec"
"os/user"
"path/filepath"
"regexp"
"runtime"
"strconv"
"strings"
Expand Down Expand Up @@ -384,14 +385,30 @@ func isGoroot(goroot string) bool {
// getGorootVersion returns the major and minor version for a given GOROOT path.
// If the goroot cannot be determined, (0, 0) is returned.
func getGorootVersion(goroot string) (major, minor int, err error) {
data, err := ioutil.ReadFile(filepath.Join(goroot, "VERSION"))
if err != nil {
var s string

if data, err := ioutil.ReadFile(filepath.Join(
goroot, "src", "runtime", "internal", "sys", "zversion.go")); err == nil {

r := regexp.MustCompile("const TheVersion = `(.*)`")
matches := r.FindSubmatch(data)
if len(matches) != 2 {
return 0, 0, errors.New("Invalid go version output:\n" + string(data))
}

s = string(matches[1])

} else if data, err := ioutil.ReadFile(filepath.Join(goroot, "VERSION")); err == nil {
s = string(data)

} else {
return 0, 0, err
}
s := string(data)
if s[:2] != "go" {

if s == "" || s[:2] != "go" {
return 0, 0, errors.New("could not parse Go version: version does not start with 'go' prefix")
}

parts := strings.Split(s[2:], ".")
if len(parts) < 2 {
return 0, 0, errors.New("could not parse Go version: version has less than two parts")
Expand Down