Conversation
|
'Test' is here https://github.com/grol-io/grol/blob/v0.24.0/ast/modify_test.go#L130 panics without this fix, also https://github.com/google/go-cmp/blob/v0.6.0/cmp/compare.go#L312-L314 in the comment hopefully makes it clear how this helps |
aykevl
left a comment
There was a problem hiding this comment.
This will make it very difficult to debug existing code that calls MethodByName: now it's very difficult to find why existing code (that calls MethodByName) works differently in TinyGo. Therefore, I think this is a bad idea.
|
Would it be possible to change go-cmp instead to not call MethodByName? |
|
I don't think go-cmp are (or should be, really) concerned with adding special case for incomplete go, so it would need to be on tinygo's side (or users of both like me) Not sure btw that it's hard to find callers without panic maybe something with some build tag then? |
Splitting commits from #4356