transform: optimize range over []byte(string) #4523
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
The test failures don't seem relevant, but I could easily be mistaken. |
Member
|
The fix for nix is in... or at least for the CI. Please rebase against latest dev. |
Member
|
LGTM but I really want @aykevl's take on this. |
dgryski
reviewed
Oct 18, 2024
| return false | ||
| } | ||
| } else { | ||
| case !use.IsALoadInst().IsNil(): |
Member
There was a problem hiding this comment.
Maybe add a comment to this block so it doesn't get lost next to the default label?
aykevl
approved these changes
Oct 18, 2024
Member
aykevl
left a comment
aykevl
left a comment
There was a problem hiding this comment.
Yes this looks reasonable (and I agree a comment before default: would look slightly better).
eliasnaur
force-pushed
the
bytestrings
branch
from
fffaac9 to
a708994
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.