Skip to content

ci: try to fix race condition in testdata/goroutines.go #4854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
deadprogram merged 1 commit into from
Apr 12, 2025
Merged

ci: try to fix race condition in testdata/goroutines.go #4854

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions testdata/goroutines.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,12 +62,15 @@ func main() {
time.Sleep(2 * time.Millisecond)

var m sync.Mutex
var wg sync.WaitGroup
m.Lock()
println("pre-acquired mutex")
go acquire(&m)
wg.Add(1)
go acquire(&m, &wg)
time.Sleep(2 * time.Millisecond)
println("releasing mutex")
m.Unlock()
wg.Wait()
time.Sleep(2 * time.Millisecond)
m.Lock()
println("re-acquired mutex")
Expand All @@ -89,8 +92,9 @@ func main() {
<-done
}

func acquire(m *sync.Mutex) {
func acquire(m *sync.Mutex, wg *sync.WaitGroup) {
m.Lock()
wg.Done()
println("acquired mutex from goroutine")
time.Sleep(2 * time.Millisecond)
println("releasing mutex from goroutine")
Expand Down
Loading