Add ESP32-S3 support #5091
Merged
Add ESP32-S3 support #5091
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Updated to pass the checks and to correct a critical bug in the linker script. This eliminated the need for -opt=0 in the two test cases I had. |
Member
|
I have a Xiao ESP32S3 board I can test with. Will take a look soon. |
Member
|
I added a board target locally, and was able to get my Xiao blinking! $ tinygo flash -size short -target xiao-esp32s3 examples/blinky1
code data bss | flash ram
3710 0 4184 | 3710 4184
esptool.py v4.8.1
Serial port /dev/ttyACM0
Connecting...
Chip is ESP32-S3 (QFN56) (revision v0.2)
Features: WiFi, BLE, Embedded PSRAM 8MB (AP_3v3)
Crystal is 40MHz
MAC: e8:06:90:9d:b5:c4
Uploading stub...
Running stub...
Stub running...
Configuring flash size...
Flash will be erased from 0x00000000 to 0x00000fff...
Flash params set to 0x031f
SHA digest in image updated
Compressed 3808 bytes to 2958...
Wrote 3808 bytes (2958 compressed) at 0x00000000 in 0.1 seconds (effective 488.0 kbit/s)...
Hash of data verified.
Leaving...
Hard resetting via RTS pin...I am thinking to squash/merge this, and then in a separate PR I will add my new target. |
Contributor
|
Ship it, @deadprogram |
Member
|
Thank you very much to everyone who has worked on this so far, @denysvitali @ofauchon @cjpeterson and a cast oof thousands! :) Now squash/merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an update to an old PR #3937 . Since the old PR has not been touched in quite a while, I figured it was worth another shot.
This adds support for the ESP32-S3 chip. Currently, serial output is working through UART. I count 3 people that have gotten text to output successfully with this code. I have also finished setting up GPIO support, so blinky is working.
Some programs compile, but freeze during execution. This seems to happen when the compiler optimizes out dead code (e.g. code after infinite loops). Adding -opt=0 during compilation has fixed all the issues I've seen.
Most of the comments from the previous pull request have been addressed:
I did not move the .S files out of /src/device/esp. It may be a good idea, but it seems beyond the scope of this PR.