Skip to content

Allow turning screen off without reboot #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
G4lile0 merged 1 commit into from
Jan 5, 2026
+27 −16
Merged

Allow turning screen off without reboot #284

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 26 additions & 15 deletions tinyGS/src/Display/Display.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ unsigned long tick_interval;
int tick_timing = 100;
int graphVal = 1;
int delta = 1;
uint8_t oldOledBright = 100;
uint8_t oldOledBright = -1; // to force brightness update on first run

void displayInit()
{
Expand Down Expand Up @@ -117,19 +117,6 @@ void msOverlay(OLEDDisplay *display, OLEDDisplayUiState* state)
{
if (timeinfo->tm_hour < 6 || timeinfo->tm_hour > 18) display->normalDisplay(); else display->invertDisplay(); // change the OLED according to the time.
}


if (oldOledBright!=ConfigManager::getInstance().getOledBright())
{
oldOledBright = ConfigManager::getInstance().getOledBright();
if (ConfigManager::getInstance().getOledBright()==0) {
display->displayOff();
}
else
{
display->setBrightness(2*ConfigManager::getInstance().getOledBright());
}
}
}

void drawRemoteFrame(OLEDDisplay *display, OLEDDisplayUiState* state, int16_t x, int16_t y, uint8_t frameNumber)
Expand Down Expand Up @@ -348,15 +335,39 @@ void displayShowStaMode(bool ap)
display->display();
}

/**
* Updates the display brightness based on the configuration.
* If the brightness has changed, it sets the new brightness or turns off the display.
* Also updates the UI if screen is on.
*/
void displayUpdate()
{
if (ConfigManager::getInstance().getOledBright())
// Get the current OLED brightness from configuration
uint8_t oledBright = ConfigManager::getInstance().getOledBright();

// Check if brightness has changed
if (oldOledBright != oledBright) {
if (oledBright) {
// Set the new brightness
display->setBrightness(2*oledBright);
} else {
// Turn off the display if brightness is 0
displayTurnOff();
}
// Save the brightness value
oldOledBright = oledBright;
}

if (oledBright) {
// Update the UI if screen is on
ui->update();
}
}

void displayTurnOff()
{
display->displayOff();
oldOledBright = 0;
}

void displayNextFrame() {
Expand Down
2 changes: 1 addition & 1 deletion tinyGS/tinyGS.ino
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,7 +322,7 @@ void loop() {
mqtt.loop();
OTA::loop();

if (configManager.getOledBright () != 0) displayUpdate ();
displayUpdate ();

if (configManager.askedWebLogin () && mqtt.connected ())
{
Expand Down