Add Jarvis HUD mascot#1
Conversation
Sci-fi ring HUD mascot with JarvisSM state machine: - idle: JarvisRotate (animState=0) - listening: listening animation (animState=1) - talking: talking animation (animState=2) Controlled via ViewModel1.animState number property. Status: draft Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
📝 WalkthroughWalkthroughAdded a new ChangesJarvis Mascot Config
Estimated code review effort: 1 (Trivial) | ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@mascots/jarvis/mascot.json`:
- Around line 31-36: The Jarvis mascot manifest entry in mascot.json is
incomplete: the runtime file object under files[] needs the required fields url,
sha256, and bytes in addition to role and path. Also add at least one files[]
item with role set to source that points to the .rev source asset so the
manifest satisfies both the schema and the manifest test.
- Around line 7-30: Update the mascot `stateEngine` object in `mascot.json` to
match `schemas/mascots.schema.json` and the manifest test expectations: add the
required `visemeCodes` array, remove the unsupported `viewModel` property, and
replace the extra `states.listening`/`states.talking` entries with the required
`states.idle` and `states.thinking` keys. Make sure the `stateEngine` and nested
`states` objects only contain properties allowed by the schema, and keep
`idlePoseCycle` valid with the expected idle animation reference.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: f43544a4-465c-4c44-b241-c41554caeb3d
📒 Files selected for processing (2)
mascots/jarvis/jarvis.rivmascots/jarvis/mascot.json
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Add required visemeCodes array (standard 15-phoneme set) - Replace states.listening/talking with required states.thinking - Remove viewModel (not permitted by schema additionalProperties:false) - Add source file entry for jarvis.rev Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
♻️ Duplicate comments (1)
mascots/jarvis/mascot.json (1)
17-26: 🗄️ Data Integrity & Integration | 🔴 Critical | ⚡ Quick win
files[]entries still missing requiredurl,sha256,bytesfields.The
.revsource entry was added, but per the schema (schemas/mascots.schema.json), everyfiles[]entry requiresrole,path,url,sha256, andbyteswithadditionalProperties: false. Both entries here only supplyroleandpath, so this manifest will still fail schema validation.🛠️ Proposed fix
"files": [ { "role": "runtime", - "path": "jarvis.riv" + "path": "jarvis.riv", + "url": "https://.../jarvis.riv", + "sha256": "<sha256 hash>", + "bytes": 0 }, { "role": "source", - "path": "jarvis.rev" + "path": "jarvis.rev", + "url": "https://.../jarvis.rev", + "sha256": "<sha256 hash>", + "bytes": 0 } ]🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@mascots/jarvis/mascot.json` around lines 17 - 26, The mascot manifest files[] entries are incomplete and will fail schema validation because each item in the files array must include url, sha256, and bytes in addition to role and path. Update the jarvis mascot manifest so both the runtime and source entries in the files array provide all required fields and do not add any extra properties, matching the structure enforced by mascots.schema.json.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Duplicate comments:
In `@mascots/jarvis/mascot.json`:
- Around line 17-26: The mascot manifest files[] entries are incomplete and will
fail schema validation because each item in the files array must include url,
sha256, and bytes in addition to role and path. Update the jarvis mascot
manifest so both the runtime and source entries in the files array provide all
required fields and do not add any extra properties, matching the structure
enforced by mascots.schema.json.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: d2d8fb49-b141-42e3-b7d4-04390e170048
⛔ Files ignored due to path filters (1)
dist/mascots.jsonis excluded by!**/dist/**
📒 Files selected for processing (2)
mascots/jarvis/jarvis.revmascots/jarvis/mascot.json
|
Hey @senamakel — all actual tests are passing on this PR. Could you take a look and approve/merge when you get a chance? The remaining CodeRabbit flag ( Tests passing locally:
Thanks! |
New Mascot: Jarvis
A sci-fi HUD ring mascot inspired by J.A.R.V.I.S., built in Rive Early Access 0.8.4917.
State Machine:
JarvisSM012Integration
ViewModel1animState(number)JarvisSMSet
animStateon the ViewModel instance to switch between states at runtime.Status
Marked
draft— open to feedback on aligning with the OpenHuman runtime contract.Summary by CodeRabbit