fix(updater): quiet passive check failures#1685
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR adds graceful error handling to the app update checker. A new helper function constructs a consistent "no update available" response, and the update check command now returns this response instead of propagating errors when checks fail or find no updates, preventing error spam to the frontend. ChangesUpdate Check Resilience
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Ok(None)and reachability failures.Closes #1614.
Validation
rustfmt app\src-tauri\src\lib.rs --edition 2021 --checkgit diff --checkcargo test --manifest-path app\src-tauri\Cargo.toml no_app_update_available_result_is_quiet_unavailable --libcannot finish on this Windows machine because native build dependencies are missing:libclangforwhisper-rs-sysandninjaforcef-dll-sys.node scripts\codex-pr-preflight.mjs --lightweightstill reports missing repo filedocs/src/README.md; all other relevant checks, including branch naming and changed file readability, pass.Summary by CodeRabbit
Bug Fixes
Tests