Skip to content

fix(updater): quiet passive check failures#1685

Merged
senamakel merged 1 commit into
tinyhumansai:mainfrom
aqilaziz:codex/OH-1614-update-check-graceful-skip
May 13, 2026
Merged

fix(updater): quiet passive check failures#1685
senamakel merged 1 commit into
tinyhumansai:mainfrom
aqilaziz:codex/OH-1614-update-check-graceful-skip

Conversation

@aqilaziz
Copy link
Copy Markdown
Contributor

@aqilaziz aqilaziz commented May 13, 2026

Summary

  • Treat passive app updater probe failures as a quiet "no update available" result instead of returning an error to the auto-check path.
  • Reuse the same unavailable result shape for both Ok(None) and reachability failures.
  • Keep manual download/apply flows unchanged, so explicit update attempts still emit error status when they fail.

Closes #1614.

Validation

  • PASS: rustfmt app\src-tauri\src\lib.rs --edition 2021 --check
  • PASS: git diff --check
  • BLOCKED: cargo test --manifest-path app\src-tauri\Cargo.toml no_app_update_available_result_is_quiet_unavailable --lib cannot finish on this Windows machine because native build dependencies are missing: libclang for whisper-rs-sys and ninja for cef-dll-sys.
  • BLOCKED: node scripts\codex-pr-preflight.mjs --lightweight still reports missing repo file docs/src/README.md; all other relevant checks, including branch naming and changed file readability, pass.

Summary by CodeRabbit

  • Bug Fixes

    • Improved app update checking to consistently report unavailable status when no updates are found or checks fail, preventing unnecessary error messages.
  • Tests

    • Added unit test for update availability checks.

Review Change Stack

@aqilaziz aqilaziz requested a review from a team May 13, 2026 20:34
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 13, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 80412a89-4053-467f-ace2-976005fa5d9d

📥 Commits

Reviewing files that changed from the base of the PR and between 2b64ea8 and a08da5b.

📒 Files selected for processing (1)
  • app/src-tauri/src/lib.rs

📝 Walkthrough

Walkthrough

This PR adds graceful error handling to the app update checker. A new helper function constructs a consistent "no update available" response, and the update check command now returns this response instead of propagating errors when checks fail or find no updates, preventing error spam to the frontend.

Changes

Update Check Resilience

Layer / File(s) Summary
Helper function and error-handling integration
app/src-tauri/src/lib.rs
Introduced no_app_update_available() helper that builds an AppUpdateInfo with available=false and optional fields unset. Updated check_app_update to use this helper for both "no update found" (Ok(None)) and "check failed" (Err) paths, replacing error propagation with graceful unavailability. Added unit test validating the helper produces consistent quiet "unavailable" responses.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 When updates fail to reach the shore,
No error floods the Sentry door,
A gentle "no" is whispered back,
No network tears, no auth attack,
Just graceful calm, forevermore.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: converting passive update check failures to quiet unavailable responses instead of errors.
Linked Issues check ✅ Passed The PR implements the 'graceful skip' mitigation from issue #1614 by treating passive check failures as quiet 'no update available' responses, directly addressing the noisy Sentry events from restricted regions.
Out of Scope Changes check ✅ Passed All changes are scoped to the update checker graceful failure handling; no unrelated modifications to other systems or manual download flows.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@senamakel senamakel merged commit a01c7d3 into tinyhumansai:main May 13, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update checker broken for users in China and rate-limited regions (403/404/network errors)

2 participants