chore(scripts): sweep remaining yarn references to pnpm (post-#886 migration)#1872
Conversation
…nsai#886 migration) The yarn → pnpm migration in tinyhumansai#886 left stale `yarn` invocations in six scripts. Three actively shell out to `yarn`, which fails on every fresh contributor's machine since `yarn` isn't part of the documented prereq set (CONTRIBUTING.md only mentions pnpm). The other three are misleading string mentions in error messages, comments, or auto-generated docs. Active invocations (would fail at runtime): - scripts/worktree-bootstrap.sh — 4 calls (install, core:stage, tauri:ensure, dev:app) - scripts/test-ci-local.sh — 5 calls (install --frozen-lockfile ×2, build ×2, tauri build) - scripts/release/local-dmg-version-dry-run.sh — 1 call (tauri build) Prose mentions (misleading, point new contributors at the wrong tool): - scripts/debug-composio-trigger.mjs — `yarn install` in the "socket.io-client missing" error hint. - scripts/tools-generator/openClaw-formatter.js — `yarn tools:generate` in the auto-generated tools.md footer. - scripts/debug-agent-prompts.sh — `yarn tauri dev` in a header comment. All 12 substitutions are 1:1 pnpm-compatible (same flag names — pnpm supports `--frozen-lockfile` — same subcommand structure for `tauri *`, `install`, `build`, custom scripts like `core:stage` / `tauri:ensure` / `dev:app` / `tools:generate`). Net diff: 6 files, +12 −12. No behavior change for the scripts that worked (they didn't, on a pnpm-only machine). The active scripts now actually run; the prose mentions now point at the right tool.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
📝 WalkthroughWalkthroughSix script files are updated to replace all Changesyarn to pnpm script migration
🎯 1 (Trivial) | ⏱️ ~3 minutes
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint skipped: no ESLint configuration detected in root package.json. To enable, add Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
well done |
Summary
Replaces all twelve
yarnsubstrings across six scripts underscripts/withpnpm, so they actually run on a clean contributor machine (pnpm is the documented prereq; yarn isn't installed) and stop pointing new contributors at the wrong tool.Problem
grep -rn "yarn" scripts/returns twelve substrings across six files post-migration:scripts/worktree-bootstrap.sh(4),scripts/test-ci-local.sh(5),scripts/release/local-dmg-version-dry-run.sh(1).scripts/debug-composio-trigger.mjs(error message),scripts/tools-generator/openClaw-formatter.js(auto-generated doc footer),scripts/debug-agent-prompts.sh(header comment).All flags and subcommands map 1:1 to pnpm (
--frozen-lockfile,--target,--bundles,--config,tauri *,install,build, project scripts).Solution
Single search-and-replace
sed -i '' 's/yarn /pnpm /g'across the six files. Verified noyarnsubstring is immediately followed by a non-space character (which would meanyarnis part of a longer word that would get clobbered). Net diff: 6 files, +12 -12.Submission Checklist
yarninvocation).scripts/release/local-dmg-version-dry-run.shwhich is a developer dry-run helper).Closes #1871in the## Relatedsection.Impact
Fresh contributors who try
bash scripts/worktree-bootstrap.shorbash scripts/test-ci-local.sh --manualno longer hityarn: command not found. The auto-generated tools.md footer (viascripts/tools-generator/openClaw-formatter.js) now points readers at the right command.Related
yarnafter the pnpm migration (#886) #1871yarn core:stagestrings and fixed those; this PR sweeps the rest).AI Authored PR Metadata (required for Codex/Linear PRs)
Linear Issue
Commit & Branch
chore/scripts-yarn-to-pnpmfa1628c7Validation Run
.mjserror-message string).Validation Blocked
command:pre-push hookpnpm rust:check(cargo check --manifest-path src-tauri/Cargo.toml) may still exit 101 on upstreammain(inherited failure documented in fix(scripts): codesign setup pops keychain dialog on every build + dr… #1786). This branch only edits shell scripts so the failure cannot be caused by this change.error:(as above)impact:Pushed with--no-verifyperCLAUDE.mdguidance for hook failures unrelated to the change.Behavior Changes
pnpminstead ofyarn, so they run on a documented-prereq machine.worktree-bootstrap.sh,test-ci-local.sh, or the local DMG dry-run no longer need a non-documented yarn install; the auto-generated tools.md footer no longer points readers at the wrong tool.Parity Contract
Duplicate / Superseded PR Handling
Summary by CodeRabbit