feat(migration): OpenClaw import surface + unblock unified-core Apply#2087
Merged
Conversation
Contributor
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (30)
✅ Files skipped from review due to trivial changes (11)
🚧 Files skipped from review as they are similar to previous changes (18)
📝 WalkthroughWalkthroughAdds a MigrationPanel UI for previewing and applying OpenClaw imports, i18n and settings routing, frontend tests, and backend changes to enable writable migration memory and an integration apply test. ChangesOpenClaw Migration Feature
Sequence DiagramsequenceDiagram
participant User
participant MigrationPanel
participant TauriRPC
User->>MigrationPanel: Select vendor & enter source path
User->>MigrationPanel: Click Preview
MigrationPanel->>TauriRPC: openhumanMigrateOpenclaw(dry_run=true, source)
TauriRPC-->>MigrationPanel: MigrationReport (preview)
MigrationPanel->>User: Display preview report
User->>MigrationPanel: Click Apply
MigrationPanel->>User: window.confirm()
alt User confirms
MigrationPanel->>TauriRPC: openhumanMigrateOpenclaw(dry_run=false, source)
TauriRPC-->>MigrationPanel: MigrationReport (applied)
MigrationPanel->>User: Display applied report
else User cancels
MigrationPanel->>User: Keep preview report
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related issues
Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint skipped: no ESLint configuration detected in root package.json. To enable, add Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
coderabbitai
Bot
added
feature
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (1)
app/src/components/settings/panels/__tests__/MigrationPanel.test.tsx (1)
102-111: ⚡ Quick winAdd a regression test for stale preview invalidation.
Please add a case that edits
sourcePathafter a successful preview and assertsApplyis disabled until re-preview succeeds for the new input.Also applies to: 113-148
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@app/src/components/settings/panels/__tests__/MigrationPanel.test.tsx` around lines 102 - 111, Add a new test in MigrationPanel.test.tsx that verifies stale preview invalidation: render <MigrationPanel />, mock openhumanMigrateOpenclaw to resolve for the initial input and click the 'migration-preview-button' (using the 'migration-source-input' test id) and assert the Apply control (e.g. test id 'migration-apply-button' or the Apply button text) becomes enabled; then change the source input value to a different path, assert that Apply becomes disabled immediately (stale preview), then mock openhumanMigrateOpenclaw to resolve for the new trimmed path, click the preview button again and finally assert Apply is enabled again. Reference openhumanMigrateOpenclaw, MigrationPanel, 'migration-source-input', 'migration-preview-button', and the Apply button test id/name when implementing the test.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@app/src/components/settings/panels/MigrationPanel.tsx`:
- Around line 38-39: The Apply button is enabled by any existing previewReport
even if the user has changed sourcePath afterward; update the gating logic so
Apply is only allowed when the previewReport corresponds to the current
sourcePath and no apply is in progress. Concretely, track and compare the
previewed path (e.g., add/derive a previewedSourcePath from previewReport or
store lastPreviewedSourcePath when preview completes) and change canApply (and
the checks around runApply, preview button handlers, and any uses at the apply
call sites) to require previewedSourcePath === sourcePath && !isApplying
(instead of just previewReport != null). Ensure runApply uses the validated
sourcePath that matches the previewed path.
- Around line 70-75: The confirmation dialog in MigrationPanel (the
window.confirm call that builds the message using totalPlanned and
previewReport.source_workspace/target_workspace) and the Hermes roadmap copy
later (around the other hardcoded strings noted) are hardcoded and must be
localized; replace the inline strings with calls to the translation function (t)
from your i18n hook (useTranslation/t) and create descriptive translation keys,
use pluralization/interpolation for totalPlanned (e.g.,
t('migration.confirmImport', {count: totalPlanned})) and interpolate
previewReport.source_workspace and previewReport.target_workspace into the
translated string, and update the Hermes roadmap text similarly so all
user-facing text in MigrationPanel uses t(...) with appropriate keys and
variables.
In `@docs/TEST-COVERAGE-MATRIX.md`:
- Line 473: The coverage summary totals need updating because the "Migration
from another assistant (OpenClaw)" row changed from ❌ to ✅; update the summary
row(s) that aggregate Covered and Missing counts to increment Covered by 1 and
decrement Missing by 1 (and recompute any dependent totals/percentages) so the
overall totals reflect this PR's change; look for the summary totals section
that references the matrix totals and adjust the numeric values accordingly.
---
Nitpick comments:
In `@app/src/components/settings/panels/__tests__/MigrationPanel.test.tsx`:
- Around line 102-111: Add a new test in MigrationPanel.test.tsx that verifies
stale preview invalidation: render <MigrationPanel />, mock
openhumanMigrateOpenclaw to resolve for the initial input and click the
'migration-preview-button' (using the 'migration-source-input' test id) and
assert the Apply control (e.g. test id 'migration-apply-button' or the Apply
button text) becomes enabled; then change the source input value to a different
path, assert that Apply becomes disabled immediately (stale preview), then mock
openhumanMigrateOpenclaw to resolve for the new trimmed path, click the preview
button again and finally assert Apply is enabled again. Reference
openhumanMigrateOpenclaw, MigrationPanel, 'migration-source-input',
'migration-preview-button', and the Apply button test id/name when implementing
the test.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 5e9d9364-d4d6-47e0-b028-9124cc8b089a
📒 Files selected for processing (8)
app/src/components/settings/panels/MigrationPanel.tsxapp/src/components/settings/panels/__tests__/MigrationPanel.test.tsxapp/src/lib/i18n/en.tsapp/src/pages/Settings.tsxdocs/TEST-COVERAGE-MATRIX.mdsrc/openhuman/memory/store/factories.rssrc/openhuman/migration/core.rssrc/openhuman/migration/ops.rs
obchain
added a commit
to obchain/openhuman
that referenced
this pull request
May 18, 2026
Address CodeRabbit review on PR tinyhumansai#2087: 1. `MigrationPanel.tsx` — track `{ vendor, source }` snapshot of the last successful preview. Apply now requires that snapshot to match the currently-typed input, so editing the path after a preview re-locks Apply until the user previews the new value. Previously Apply unlocked on any prior preview, letting the user mutate a workspace they had never seen the diff for. 2. `MigrationPanel.tsx` — localize the Hermes "coming soon" callout and the Apply confirm() body via `t(...)` with three new keys (`hermesComingSoonPrefix/Suffix/LinkText`, `confirmImport.singular`, `confirmImport.plural`). Tests cover the new gate behavior. 3. `docs/TEST-COVERAGE-MATRIX.md` — rebalance Covered/Missing totals to reflect the OpenClaw migration row moving ❌ → ✅ (Covered 65→66, Missing 27→26).
obchain
added a commit
to obchain/openhuman
that referenced
this pull request
May 18, 2026
CI `i18n:check` failed on PR tinyhumansai#2087 because the migration.* keys (added to en.ts) had no presence in the chunks/ source-of-truth that the coverage tool uses for drift + per-locale checks. Add the 28 new `migration.*` keys to chunks/en-1.ts plus `pages.settings.account.migration{Desc}` to chunks/en-4.ts, then seed English fallbacks into all 10 non-en locale chunks so per-locale "missing" passes. Translators can replace the English placeholders in a follow-up.
obchain
force-pushed
the
feat/1440-migration-panel
branch
from
1f04fac to
65b42cc
Compare
Contributor
There was a problem hiding this comment.
Actionable comments posted: 9
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@app/src/lib/i18n/chunks/ar-1.ts`:
- Around line 375-410: The Arabic locale chunk includes new migration.* keys in
English; translate each migration.* string (e.g., migration.title,
migration.description, migration.vendorLabel, migration.sourceLabel,
migration.sourcePlaceholder, migration.sourceHint, migration.previewAction,
migration.previewRunning, migration.applyAction, migration.applyRunning,
migration.applyDisclaimer, migration.reportTitlePreview,
migration.reportTitleApplied, migration.report.source, migration.report.target,
migration.report.fromSqlite, migration.report.fromMarkdown,
migration.report.imported, migration.report.skippedUnchanged,
migration.report.renamedConflicts, migration.report.warnings,
migration.report.previewHint, migration.report.appliedHint,
migration.hermesComingSoonPrefix, migration.hermesComingSoonSuffix,
migration.hermesLinkText, migration.confirmImport.singular,
migration.confirmImport.plural) into Arabic so users of the ar chunk see
localized text; preserve formatting/escapes (e.g., "\\n\\n") and placeholders
({count}, {source}, {target}) exactly when replacing the English strings.
In `@app/src/lib/i18n/chunks/bn-1.ts`:
- Around line 383-418: The Bengali locale chunk still contains English strings
for all migration.* keys; update each migration.* entry (e.g.,
'migration.title', 'migration.description', 'migration.vendorLabel',
'migration.sourceLabel', 'migration.sourcePlaceholder', 'migration.sourceHint',
'migration.previewAction', 'migration.previewRunning', 'migration.applyAction',
'migration.applyRunning', 'migration.applyDisclaimer',
'migration.reportTitlePreview', 'migration.reportTitleApplied',
'migration.report.source', 'migration.report.target',
'migration.report.fromSqlite', 'migration.report.fromMarkdown',
'migration.report.imported', 'migration.report.skippedUnchanged',
'migration.report.renamedConflicts', 'migration.report.warnings',
'migration.report.previewHint', 'migration.report.appliedHint',
'migration.hermesComingSoonPrefix', 'migration.hermesComingSoonSuffix',
'migration.hermesLinkText', 'migration.confirmImport.singular',
'migration.confirmImport.plural') with proper Bengali translations so the UI
shows localized text; preserve placeholders like {count}, {source}, {target} and
the escaped newline sequences (\\n\\n) and ensure punctuation/grammar match
Bengali usage.
In `@app/src/lib/i18n/chunks/hi-4.ts`:
- Around line 366-368: The Hindi localization is missing translations for the
keys 'pages.settings.account.migration' and
'pages.settings.account.migrationDesc'; update the hi-4.ts chunk by replacing
the English strings for those symbols with proper Hindi translations that convey
"Import from another assistant" and "Migrate memory and notes from OpenClaw (or,
soon, Hermes) into this workspace." respectively, preserving the existing key
names and string formatting (quotes, trailing comma).
In `@app/src/lib/i18n/chunks/id-1.ts`:
- Around line 383-418: The migration.* entries are still in English so the
Indonesian locale lacks translations; update each key (e.g., migration.title,
migration.description, migration.vendorLabel, migration.sourceLabel,
migration.sourcePlaceholder, migration.sourceHint, migration.previewAction,
migration.previewRunning, migration.applyAction, migration.applyRunning,
migration.applyDisclaimer, migration.reportTitlePreview,
migration.reportTitleApplied, migration.report.source, migration.report.target,
migration.report.fromSqlite, migration.report.fromMarkdown,
migration.report.imported, migration.report.skippedUnchanged,
migration.report.renamedConflicts, migration.report.warnings,
migration.report.previewHint, migration.report.appliedHint,
migration.hermesComingSoonPrefix, migration.hermesComingSoonSuffix,
migration.hermesLinkText, migration.confirmImport.singular,
migration.confirmImport.plural) with proper Indonesian translations consistent
with existing style and tone, ensuring escaped newlines (\\n) remain where
present and keeping placeholders like {count}, {source}, {target} intact.
In `@app/src/lib/i18n/chunks/it-1.ts`:
- Around line 388-423: Replace the English strings for all migration.* keys in
this file (e.g., 'migration.title', 'migration.description',
'migration.vendorLabel', 'migration.sourceLabel', 'migration.sourcePlaceholder',
'migration.sourceHint', 'migration.previewAction', 'migration.previewRunning',
'migration.applyAction', 'migration.applyRunning', 'migration.applyDisclaimer',
'migration.reportTitlePreview', 'migration.reportTitleApplied',
'migration.report.source', 'migration.report.target',
'migration.report.fromSqlite', 'migration.report.fromMarkdown',
'migration.report.imported', 'migration.report.skippedUnchanged',
'migration.report.renamedConflicts', 'migration.report.warnings',
'migration.report.previewHint', 'migration.report.appliedHint',
'migration.hermesComingSoonPrefix', 'migration.hermesComingSoonSuffix',
'migration.hermesLinkText', 'migration.confirmImport.singular',
'migration.confirmImport.plural') with accurate Italian translations so the UI
shows Italian text consistently; keep placeholders like {count}, {source},
{target} and escaped newlines (\\n) unchanged and preserve punctuation and
intent of each message.
In `@app/src/lib/i18n/chunks/it-4.ts`:
- Around line 368-370: Translate the two English keys into Italian in
app/src/lib/i18n/chunks/it-4.ts: replace 'pages.settings.account.migration'
value with an Italian label (e.g., "Importa da un altro assistente") and update
'pages.settings.account.migrationDesc' to an Italian sentence (e.g., "Migra
memorie e note da OpenClaw (o, presto, Hermes) in questo spazio di lavoro.") so
both keys (pages.settings.account.migration and
pages.settings.account.migrationDesc) are localized consistently.
In `@app/src/lib/i18n/chunks/pt-4.ts`:
- Around line 368-370: The two new keys 'pages.settings.account.migration' and
'pages.settings.account.migrationDesc' in the pt-4 translation chunk are still
in English; replace their English strings with Portuguese translations (e.g.,
'Importar de outro assistente' for 'pages.settings.account.migration' and a
natural Portuguese sentence for 'pages.settings.account.migrationDesc' such as
'Migrar memórias e notas do OpenClaw (ou, em breve, Hermes) para este espaço de
trabalho.') so Portuguese users see localized account menu content.
In `@app/src/lib/i18n/chunks/zh-CN-1.ts`:
- Around line 365-400: The migration.* entries in zh-CN-1.ts are still in
English (e.g. 'migration.title', 'migration.vendorLabel',
'migration.previewAction', 'migration.confirmImport.singular' etc.), so replace
the English values with proper Simplified Chinese translations for all 36
migration.* keys in that file; preserve formatting and escape sequences (e.g.
"\\n\\n") and keep the same keys and punctuation, only changing the string
values to Chinese (for example 'migration.title' → '从其他助手导入',
'migration.vendorLabel' → '源供应商', 'migration.previewAction' → '预览').
In `@app/src/lib/i18n/chunks/zh-CN-4.ts`:
- Around line 362-364: The two i18n keys pages.settings.account.migration and
pages.settings.account.migrationDesc contain English text in the Simplified
Chinese chunk; replace their values with the provided Chinese translations so
Chinese users see localized text — set pages.settings.account.migration to
"从其他助手导入" and pages.settings.account.migrationDesc to "将来自 OpenClaw（或即将支持的
Hermes）的记忆和笔记迁移到此工作区。".
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 196ca957-9e4a-4e6d-b286-370b6f80e90e
📒 Files selected for processing (30)
app/src/components/settings/panels/MigrationPanel.tsxapp/src/components/settings/panels/__tests__/MigrationPanel.test.tsxapp/src/lib/i18n/chunks/ar-1.tsapp/src/lib/i18n/chunks/ar-4.tsapp/src/lib/i18n/chunks/bn-1.tsapp/src/lib/i18n/chunks/bn-4.tsapp/src/lib/i18n/chunks/en-1.tsapp/src/lib/i18n/chunks/en-4.tsapp/src/lib/i18n/chunks/es-1.tsapp/src/lib/i18n/chunks/es-4.tsapp/src/lib/i18n/chunks/fr-1.tsapp/src/lib/i18n/chunks/fr-4.tsapp/src/lib/i18n/chunks/hi-1.tsapp/src/lib/i18n/chunks/hi-4.tsapp/src/lib/i18n/chunks/id-1.tsapp/src/lib/i18n/chunks/id-4.tsapp/src/lib/i18n/chunks/it-1.tsapp/src/lib/i18n/chunks/it-4.tsapp/src/lib/i18n/chunks/pt-1.tsapp/src/lib/i18n/chunks/pt-4.tsapp/src/lib/i18n/chunks/ru-1.tsapp/src/lib/i18n/chunks/ru-4.tsapp/src/lib/i18n/chunks/zh-CN-1.tsapp/src/lib/i18n/chunks/zh-CN-4.tsapp/src/lib/i18n/en.tsapp/src/pages/Settings.tsxdocs/TEST-COVERAGE-MATRIX.mdsrc/openhuman/memory/store/factories.rssrc/openhuman/migration/core.rssrc/openhuman/migration/ops.rs
✅ Files skipped from review due to trivial changes (13)
- app/src/lib/i18n/chunks/es-1.ts
- app/src/lib/i18n/chunks/hi-1.ts
- app/src/lib/i18n/chunks/id-4.ts
- app/src/lib/i18n/chunks/en-4.ts
- app/src/lib/i18n/chunks/fr-4.ts
- app/src/lib/i18n/chunks/es-4.ts
- app/src/lib/i18n/chunks/ru-4.ts
- app/src/lib/i18n/chunks/ru-1.ts
- app/src/lib/i18n/chunks/fr-1.ts
- app/src/lib/i18n/chunks/ar-4.ts
- app/src/lib/i18n/chunks/bn-4.ts
- app/src/lib/i18n/en.ts
- app/src/lib/i18n/chunks/pt-1.ts
🚧 Files skipped from review as they are similar to previous changes (6)
- src/openhuman/migration/core.rs
- src/openhuman/memory/store/factories.rs
- app/src/components/settings/panels/tests/MigrationPanel.test.tsx
- app/src/pages/Settings.tsx
- src/openhuman/migration/ops.rs
- app/src/components/settings/panels/MigrationPanel.tsx
obchain
added a commit
to obchain/openhuman
that referenced
this pull request
May 18, 2026
CodeRabbit follow-up on PR tinyhumansai#2087: replace English fallback placeholders in all 10 non-en locale chunks (zh-CN, hi, es, ar, fr, bn, pt, ru, id, it) with real translations for the 28 `migration.*` keys plus the 2 `pages.settings.account.migration{Desc}` labels. Placeholder tokens (`{count}`, `{source}`, `{target}`) and the `tinyhumansai#1440` link text are kept verbatim. Newlines in the confirm-import bodies preserved via `\n`.
obchain
added a commit
to obchain/openhuman
that referenced
this pull request
May 18, 2026
Address CodeRabbit review on PR tinyhumansai#2087: 1. `MigrationPanel.tsx` — track `{ vendor, source }` snapshot of the last successful preview. Apply now requires that snapshot to match the currently-typed input, so editing the path after a preview re-locks Apply until the user previews the new value. Previously Apply unlocked on any prior preview, letting the user mutate a workspace they had never seen the diff for. 2. `MigrationPanel.tsx` — localize the Hermes "coming soon" callout and the Apply confirm() body via `t(...)` with three new keys (`hermesComingSoonPrefix/Suffix/LinkText`, `confirmImport.singular`, `confirmImport.plural`). Tests cover the new gate behavior. 3. `docs/TEST-COVERAGE-MATRIX.md` — rebalance Covered/Missing totals to reflect the OpenClaw migration row moving ❌ → ✅ (Covered 65→66, Missing 27→26).
obchain
added a commit
to obchain/openhuman
that referenced
this pull request
May 18, 2026
CI `i18n:check` failed on PR tinyhumansai#2087 because the migration.* keys (added to en.ts) had no presence in the chunks/ source-of-truth that the coverage tool uses for drift + per-locale checks. Add the 28 new `migration.*` keys to chunks/en-1.ts plus `pages.settings.account.migration{Desc}` to chunks/en-4.ts, then seed English fallbacks into all 10 non-en locale chunks so per-locale "missing" passes. Translators can replace the English placeholders in a follow-up.
obchain
added a commit
to obchain/openhuman
that referenced
this pull request
May 18, 2026
CodeRabbit follow-up on PR tinyhumansai#2087: replace English fallback placeholders in all 10 non-en locale chunks (zh-CN, hi, es, ar, fr, bn, pt, ru, id, it) with real translations for the 28 `migration.*` keys plus the 2 `pages.settings.account.migration{Desc}` labels. Placeholder tokens (`{count}`, `{source}`, `{target}`) and the `tinyhumansai#1440` link text are kept verbatim. Newlines in the confirm-import bodies preserved via `\n`.
obchain
force-pushed
the
feat/1440-migration-panel
branch
from
20ef55c to
ebb6bda
Compare
`create_memory_for_migration` had been left as an unconditional
`anyhow::bail!("memory migration is disabled for the unified namespace
memory core")` since the unified namespace memory landing. Every code
path that goes through it (today: the Apply phase of
`openhuman.migrate_openclaw` via `migrate_openclaw_memory`) failed
closed — Preview worked, Apply was dead.
The fix is small: under the unified core there is no separate
"migration backend", just the same workspace-scoped store the rest of
the app reads from. Delegate to `create_memory(config, workspace_dir)`
so migration writes into a real `Box<dyn Memory>`.
Signature changes from `(&str, &Path)` to `(&MemoryConfig, &Path)`
since the workspace-aware factory needs the full memory config. The
sole caller (`migration::core::target_memory_backend`) already has
`&Config` in scope, so the call site is a one-line change.
Tests: replaced the always-errors regression with a positive
`create_memory_for_migration_returns_writable_memory_on_unified_core`,
and added `migrate_openclaw_apply_imports_markdown_entries_into_target_workspace`
to exercise the full Apply path end-to-end against a temp OpenClaw
workspace.
Refs tinyhumansai#1440
Adds a Settings → Account → "Import from another assistant" panel that wraps the existing `openhuman.migrate_openclaw` RPC with a preview-then-apply flow: - Vendor dropdown (OpenClaw active; Hermes disabled with a "coming soon" callout linking back to the tracking issue). - Preview button hits the RPC with `dry_run=true` and renders the returned `MigrationReport` (source/target paths, per-source counts, warnings). - Apply is locked until a successful Preview lands and fires `window.confirm` with the planned counts before calling the RPC with `dry_run=false`. - Inline error surface survives the form so the user can edit + retry without losing context. The Rust core RPC + TS wrapper already existed; this PR ships the discoverability surface called out as the tinyhumansai#1 gap in the issue. The Apply path is unblocked by the sibling backend fix in the previous commit. Closes tinyhumansai#1440
Address CodeRabbit review on PR tinyhumansai#2087: 1. `MigrationPanel.tsx` — track `{ vendor, source }` snapshot of the last successful preview. Apply now requires that snapshot to match the currently-typed input, so editing the path after a preview re-locks Apply until the user previews the new value. Previously Apply unlocked on any prior preview, letting the user mutate a workspace they had never seen the diff for. 2. `MigrationPanel.tsx` — localize the Hermes "coming soon" callout and the Apply confirm() body via `t(...)` with three new keys (`hermesComingSoonPrefix/Suffix/LinkText`, `confirmImport.singular`, `confirmImport.plural`). Tests cover the new gate behavior. 3. `docs/TEST-COVERAGE-MATRIX.md` — rebalance Covered/Missing totals to reflect the OpenClaw migration row moving ❌ → ✅ (Covered 65→66, Missing 27→26).
CI `i18n:check` failed on PR tinyhumansai#2087 because the migration.* keys (added to en.ts) had no presence in the chunks/ source-of-truth that the coverage tool uses for drift + per-locale checks. Add the 28 new `migration.*` keys to chunks/en-1.ts plus `pages.settings.account.migration{Desc}` to chunks/en-4.ts, then seed English fallbacks into all 10 non-en locale chunks so per-locale "missing" passes. Translators can replace the English placeholders in a follow-up.
CodeRabbit follow-up on PR tinyhumansai#2087: replace English fallback placeholders in all 10 non-en locale chunks (zh-CN, hi, es, ar, fr, bn, pt, ru, id, it) with real translations for the 28 `migration.*` keys plus the 2 `pages.settings.account.migration{Desc}` labels. Placeholder tokens (`{count}`, `{source}`, `{target}`) and the `tinyhumansai#1440` link text are kept verbatim. Newlines in the confirm-import bodies preserved via `\n`.
obchain
force-pushed
the
feat/1440-migration-panel
branch
from
ebb6bda to
a350509
Compare
Contributor
|
@obchain Could you add |
mtkik
pushed a commit
to mtkik/openhuman-meet
that referenced
this pull request
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
create_memory_for_migrationfactory so the Apply path ofopenhuman.migrate_openclawactually moves data instead of bailing with "memory migration is disabled for the unified namespace memory core."13.5.4 Migration from another assistant (OpenClaw).Problem
#1440 (raised by @senamakel) flagged three things:
src/openhuman/migration/for a while with zero UI surface.dry_runtotrue, which surprises CLI/RPC callers who expect "I clicked Import, my data should move."Discovered while smoke-testing the UI: even with the panel wired, Apply was dead at the backend.
src/openhuman/memory/store/factories.rs:442hadcreate_memory_for_migrationpermanentlybail!ed with "memory migration is disabled for the unified namespace memory core" — left over from the unified namespace memory landing. Without unblocking that, the UI would have shipped half-broken: users would discover the migration surface, run Preview, click Apply, and watch it fail with a backend error nobody could action without reading Rust source.Solution
Three layers, sized to scope:
1. Backend re-enable (
src/openhuman/memory/store/factories.rs,src/openhuman/migration/core.rs)Under the unified namespace memory core there is no separate "migration backend" — the importer just needs a writable
Box<dyn Memory>rooted at the active workspace, which is exactly whatcreate_memory(config, workspace_dir)already produces.create_memory_for_migrationnow delegates tocreate_memory. Old behavior was unconditional bail.(&str, &Path)to(&MemoryConfig, &Path)so we can pass the full memory config; the sole caller (target_memory_backend) already has&Configin scope.factories.rsis replaced with a positivecreate_memory_for_migration_returns_writable_memory_on_unified_corethat pins the new contract.migrate_openclaw_apply_imports_markdown_entries_into_target_workspaceexercises the full Apply path against a temp OpenClaw workspace and assertsimported >= 1.2. Settings panel (
app/src/components/settings/panels/MigrationPanel.tsx)<select>— OpenClaw active, Hermes disabled with an honest "on the roadmap" callout that links to Simplify migration from OpenClaw and Hermes Agent into OpenHuman #1440 for context.~/.openclaw/workspace).dry_run=trueand renders the returnedMigrationReport— source/target paths, per-source counts (from_sqlite,from_markdown),imported,skipped_unchanged,renamed_conflicts, warnings.window.confirmwith the planned counts, then calls the RPC withdry_run=falseand shows the post-apply report.migrationroute + sidebar item under the Account section.migration.*andpages.settings.account.migration*. Other locales fall back to English via the existingt()fallback chain.3. Coverage matrix (
docs/TEST-COVERAGE-MATRIX.md)New row
13.5.4 Migration from another assistant (OpenClaw)— was ❌, now ✅, layerVU+RU.Why preview-then-apply (not single Import button)?
The instinct is to flip
dry_run's default. The downside: the existing RPC contract is load-bearing for any external script that's been calling it with the dry-run default. A safer UX-side fix: keep the RPC contract as-is, but make the UI explicit — Preview =dry_run=true, Apply =dry_run=false+ confirm. The user always knows which mode they're in.Submission Checklist
13.5.4indocs/TEST-COVERAGE-MATRIX.md.## Related.openhuman.migrate_openclawRPC +create_memoryfactory; no new deps.~/.openclaw/workspacewithMEMORY.md+ 2memory/*.mdfiles): Preview returnsfrom_markdown=3, imported=0; Apply succeeds (no more bail), backup directory created, report renders inline; idempotent re-Apply reportsskipped_unchanged=3.## Related. Simplify migration from OpenClaw and Hermes Agent into OpenHuman #1440 covers OpenClaw + Hermes; this PR ships OpenClaw end-to-end and leaves Simplify migration from OpenClaw and Hermes Agent into OpenHuman #1440 open for the Hermes companion (per acceptance criterion 2: "do not leave Hermes unmentioned in UX; 'coming soon' is acceptable only with linked tracking issue").Impact
openhuman.migrate_openclawunchanged (dry_runstill defaults totrueat the handler level — old CLI/RPC callers continue to behave identically).backup_target_memoryhelper was already in place; only the bail in front of it was the blocker).Related
AI Authored PR Metadata (required for Codex/Linear PRs)
Linear Issue
Commit & Branch
Validation Run
pnpm --filter openhuman-app format:checkpnpm typecheckpnpm exec vitest run --config test/vitest.config.ts src/components/settings/panels/__tests__/MigrationPanel.test.tsx— 7 passedpnpm debug rust migrate_openclaw— 6 passed (including the new Apply integration test)pnpm debug rust create_memory_for_migration— 1 passed (positive replacement of the always-errors regression)cargo check --manifest-path Cargo.toml) — clean.Validation Blocked
command:N/Aerror:N/Aimpact:N/ABehavior Changes
Parity Contract
openhuman.migrate_openclawRPC contract unchanged (dry_rundefaults totrueat the handler level). CLI / RPC callers continue to behave identically.skipped_unchanged) untouched; rename-on-conflict behavior untouched. Only the bail in front of all that is replaced.Duplicate / Superseded PR Handling
Summary by CodeRabbit
New Features
Localization
Tests
Documentation