fix(i18n): fix ~80 broken/placeholder strings in en.ts#2144
Conversation
Fixes tinyhumansai#2143 - Fix inverted labels: locked/Unlocked, paused/Enabled, inactive/Active, enableEcho/Remove Echo, showErrorDetails/Hide error details - Fix action buttons that showed loading state as their idle label: addProvider, saveChanges, saveSettings, clearHistory - Remove raw code/template literals that leaked into string values: core-runs:${job.id}, ${} {categoryId}, $${amount.toFixed(2)}, '+ .replace(', ${selected.label}, raw JS ternaries in acceptedCompletion/s, upsell.usageLimit.resetsIn, truncated fragments in defaultBody/enableDesc - Fill in ~50 placeholder stubs left from i18n auto-merge (Heading, Body, Perk1-4, Desc, Title, Subtitle, etc.) - Fix capitalization: loading→Loading, Llm→LLM, ollama→Ollama, Oauth→OAuth, Macos→macOS, ComposeIO→Composio, ids→IDs - Remove stale "sidecar" reference in statusCoreUnreachable (removed PR tinyhumansai#1061) - Add missing themeToggle keys added in upstream/main
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughUpdated many English i18n strings in ChangesEnglish Translation Fixes and Refreshes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint skipped: no ESLint configuration detected in root package.json. To enable, add Comment |
…es i18n coverage test) 17 voice-settings keys present in the en-5.ts chunk were absent from the aggregate en.ts, causing the i18n coverage test to fail in CI. Copied the values verbatim from the chunk to restore key-for-key parity.
The common.loading key was corrected from 'loading…' to 'Loading…'; update the Conversations render test to match the new value.
home.banners.getSubscription was corrected from 'get a subscription' to 'Get a subscription'; update the PromotionalCreditsBanner test to match.
Summary
app/src/lib/i18n/en.tsthat were left unresolved after the i18n auto-mergelocked→Locked,paused→Paused,inactive→Inactive,enableEcho→Enable Echo,showErrorDetails→Show error details)core-runs:${job.id},${} {categoryId},$${amount.toFixed(2)}, raw ternaries inacceptedCompletion/s, etc.)'Heading','Body','Perk1'–'Perk4','Desc','Title','Subtitle', etc.)loading→Loading,Llm→LLM,ollama→Ollama,Oauth→OAuth,Macos→macOS,ComposeIO→ComposioProblem
'Saving…'at rest, inverted toggle labels,core-runs:${job.id}appearing verbatim)home.statusCoreUnreachablestill referenced the removed "sidecar" (dropped in fix(core,cef): run core in-process and stop orphaning CEF helpers on Cmd+Q #1061)home.themeToggle.*keys added in upstream were missing from the branch baseSolution
en.tsfile and fixed every broken string in a single passsettings.mascot.voice.*keys found by the i18n coverage testhome.themeToggle.*keys from upstreamSubmission Checklist
en.tsis a data file with no executable lines; diff-cover reports 0 coverable lines on this diff## Related— N/A: no matrix entries affectedCloses #NNNin the## RelatedsectionImpact
Related
AI Authored PR Metadata (required for Codex/Linear PRs)
Linear Issue
Commit & Branch
fix/i18n-text-improvementse771b954Summary by CodeRabbit
Documentation
Tests