fix(core-state): clarify retry failure logs by okbexx · Pull Request #2167 · tinyhumansai/openhuman

okbexx · 2026-05-19T02:55:40Z

Summary

Clarifies core-state poll failure debug logs so consecutive failures beyond bootstrap no longer render impossible retry counters like 11/5.
Keeps the existing bounded console warning behavior, while the debug log now distinguishes bootstrap retries from continuous background polling after warnings are suppressed.
Adds regression coverage for post-bootstrap failure log semantics.

Fixes #2158

Files changed

app/src/providers/CoreStateProvider.tsx
app/src/providers/__tests__/CoreStateProvider.test.tsx

Validation

RED: pnpm --dir app exec vitest run --config test/vitest.config.ts src/providers/__tests__/CoreStateProvider.test.tsx -t "describes post-bootstrap poll failures without impossible retry counters" failed before implementation with TypeError: coreStatePollFailureDebugMessage is not a function.
GREEN: pnpm --dir app exec vitest run --config test/vitest.config.ts src/providers/__tests__/CoreStateProvider.test.tsx -t "describes post-bootstrap poll failures without impossible retry counters" passed.
pnpm --dir app exec vitest run --config test/vitest.config.ts src/providers/__tests__/CoreStateProvider.test.tsx passed: 16 tests.
pnpm --filter openhuman-app compile passed (tsc --noEmit; local Node warns wanted >=24.0.0, current v22.22.2).
pnpm --dir app exec eslint src/providers/CoreStateProvider.tsx src/providers/__tests__/CoreStateProvider.test.tsx passed.
git diff --check passed.
git grep -n "refresh failed attempt=%d/%d" -- app/src/providers/CoreStateProvider.tsx found no old impossible-counter format.
Pre-push hook: Prettier/Rust formatting and repo lint reached/passable stages, but the hook was blocked by the local environment items below; branch was pushed with --no-verify after the focused frontend validation above passed.

Blocked locally

pnpm --filter openhuman-app rust:check fails in this environment because Tauri glib-sys cannot find the system library metadata: Package 'glib-2.0', required by 'virtual:world', not found; glib-2.0.pc is missing and PKG_CONFIG_PATH is not set.
pnpm --dir app run lint:commands-tokens fails because rg is not installed on this host: lint:commands-tokens requires ripgrep.

Behavior / risk notes

Runtime behavior is unchanged except for diagnostic text emitted through the debug('core-state') logger on poll failures.
Console warnings remain bounded to attempts 1/5 through 5/5, then one suppression notice.
After the bootstrap retry limit, debug logs now say the poller is continuing background polling with warnings suppressed instead of formatting the consecutive failure counter as another retry attempt.

Duplicate PR check

Searched open PRs for #2158, core-state, app_state_snapshot, and poll failed; no open PR directly fixes Core-state poll retry counter exceeds its max attempts #2158.

Summary by CodeRabbit

Chores
- Enhanced diagnostic logging for core state initialization failures with intelligent attempt-based messaging to improve troubleshooting and debugging experience.

coderabbitai · 2026-05-19T02:55:53Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e31f1de9-eb8a-4e39-a6e2-d76740d41e05

📥 Commits

Reviewing files that changed from the base of the PR and between a719d78 and b417db1.

📒 Files selected for processing (2)

app/src/providers/CoreStateProvider.tsx
app/src/providers/__tests__/CoreStateProvider.test.tsx

📝 Walkthrough

Walkthrough

This PR adds a new coreStatePollFailureDebugMessage() helper function to generate attempt-aware debug messages during core-state polling failures. The function is integrated into bootstrap error handling to conditionally log messages based on failure count, replacing fixed logging. Test coverage validates the function behavior.

Changes

Core-state poll failure messaging fix

Layer / File(s)	Summary
Failure count debug message helper `app/src/providers/CoreStateProvider.tsx`	New exported `coreStatePollFailureDebugMessage()` function that maps failure counts to debug strings with distinct `nextAction` phrases for retries vs. post-limit phases, returning `null` for non-positive counts.
Bootstrap error handling integration `app/src/providers/CoreStateProvider.tsx`	Refresh-failure catch block refactored to call the message helper and conditionally emit debug logs only when a message is returned, replacing the previous unconditional fixed logging format.
Test coverage for failure messaging `app/src/providers/__tests__/CoreStateProvider.test.tsx`	Import added for the new function; new test case validates post-bootstrap failure output and confirms the message does not contain impossible retry counter formats.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

tinyhumansai/openhuman#1822: Both PRs modify CoreStateProvider.tsx's bootstrap/polling failure handling to conditionally emit attempt-based messaging via exported failure-count helper(s) and update CoreStateProvider.test.tsx to validate the failure counter/throttling wording.

Poem

🐰 A retry loop once sang too loud,
Counting 11 past its vow of 5,
Now a helper whispers in the cloud,
Keeping promise counts truthful and alive!

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'fix(core-state): clarify retry failure logs' is clear, concise, and directly summarizes the main change—improving debug messages for core-state polling failures to fix misleading retry counters.
Linked Issues check	✅ Passed	The PR successfully addresses all coding objectives from issue `#2158`: eliminates impossible retry counters (no more '11/5'), honors retry policy by distinguishing bootstrap from background polling, adds regression test coverage (one new test verified), and replaces unconditional logging with conditional debug messages.
Out of Scope Changes check	✅ Passed	All changes are directly scoped to fixing core-state poll failure logs: the helper function `coreStatePollFailureDebugMessage()` is introduced to replace misleading logs, bootstrap polling logic is updated to use it, and a test verifies post-bootstrap failure message semantics. No unrelated modifications detected.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint skipped: no ESLint configuration detected in root package.json. To enable, add eslint to devDependencies.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

graycyrus

Walkthrough

Clean, well-scoped fix for the misleading 11/5 retry counters in core-state debug logs. The new coreStatePollFailureDebugMessage helper correctly distinguishes bootstrap retries from post-bootstrap background polling, and the regression test covers all boundary cases (0, within-bootstrap, at-limit, post-bootstrap). Nice explicit 11/5 negative assertion in the test too.

File	Change	Description
`CoreStateProvider.tsx`	Enhancement	New `coreStatePollFailureDebugMessage()` with phase-aware log formatting; call site updated to use it
`CoreStateProvider.test.tsx`	Test	Regression test covering all debug message phases + impossible-counter negative assertion

One minor nit below — otherwise LGTM.

graycyrus · 2026-05-19T06:35:40Z

+    );
+    expect(postBootstrapMessage).not.toContain('11/5');
+  });
 });


[minor] This test is nested inside describe('coreStatePollFailureWarningMessage') but it exercises coreStatePollFailureDebugMessage. Consider adding a sibling describe('coreStatePollFailureDebugMessage') block so the test runner output groups them correctly.

Adds 10s poll backoff once the 5-retry bootstrap budget is exhausted, preventing tight retry loops during slow startup. Reverts to 2s on recovery. Builds on #2167 (debug message helper). - BACKOFF_POLL_MS = 10_000: scheduleNext uses longer delay after bootstrap exhaustion, 2s otherwise - coreStatePollFailureWarningMessage messages updated to say 'bootstrap poll failed' and 'budget exhausted; continuing with backoff' - Tests: backoff timing (fake timers), recovery revert, impossible-counter negative assertion, debug message describe block properly separated Closes #2158

fix(core-state): clarify retry failure logs

b417db1

okbexx requested a review from a team May 19, 2026 02:55

coderabbitai Bot approved these changes May 19, 2026

View reviewed changes

graycyrus reviewed May 19, 2026

View reviewed changes

M3gA-Mind mentioned this pull request May 19, 2026

fix(core-state): fix retry counter log and add backoff after bootstrap exhaustion #2194

Merged

5 tasks

M3gA-Mind merged commit 91a5bb9 into tinyhumansai:main May 19, 2026
26 checks passed

This was referenced May 19, 2026

fix(core-rpc): demote timeout unhandled-rejections + classify in client (#REACT-15+) #2196

Merged

Quiet core-state and rewards timeout diagnostics #2319

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(core-state): clarify retry failure logs#2167

fix(core-state): clarify retry failure logs#2167
M3gA-Mind merged 1 commit into
tinyhumansai:mainfrom
okbexx:fix/core-state-retry-log-counter

okbexx commented May 19, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented May 19, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

Uh oh!

graycyrus left a comment

Uh oh!

graycyrus May 19, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

okbexx commented May 19, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Files changed

Validation

Blocked locally

Behavior / risk notes

Duplicate PR check

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented May 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

Uh oh!

graycyrus left a comment

Choose a reason for hiding this comment

Uh oh!

graycyrus May 19, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

okbexx commented May 19, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented May 19, 2026 •

edited

Loading