Skip to content

fix(i18n): remove duplicate German mascot GIF keys#2597

Merged
senamakel merged 1 commit into
tinyhumansai:mainfrom
YOMXXX:fix/de-i18n-duplicate-keys
May 25, 2026
Merged

fix(i18n): remove duplicate German mascot GIF keys#2597
senamakel merged 1 commit into
tinyhumansai:mainfrom
YOMXXX:fix/de-i18n-duplicate-keys

Conversation

@YOMXXX
Copy link
Copy Markdown
Contributor

@YOMXXX YOMXXX commented May 25, 2026

Summary

  • Remove 3 duplicate keys in app/src/lib/i18n/chunks/de-5.ts that cause tsc --noEmit to fail with TS1117 (An object literal cannot have multiple properties with the same name).
  • customGifError, customGifHeading, customGifLabel each appeared twice (lines 243-246 and 534-537). Kept the first occurrence, removed the duplicates.

Test plan

  • pnpm typecheck passes (no more TS1117 errors)
  • pnpm lint passes (no more no-dupe-keys ESLint errors)

Three keys (customGifError, customGifHeading, customGifLabel) were
duplicated at lines 534-537, causing tsc TS1117 errors. Kept the
first occurrence (lines 243-246) and removed the later duplicates.
@YOMXXX YOMXXX requested a review from a team May 25, 2026 04:55
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 25, 2026

📝 Walkthrough

Walkthrough

German translation chunk de-5.ts was updated by removing three custom GIF mascot-related translation keys (customGifError, customGifHeading, customGifLabel) and adding new translation entries for mascot library, title, developer menu, appearance settings, and onboarding/migration/progress UI strings.

Changes

Translation Updates

Layer / File(s) Summary
German mascot and UI translation keys
app/src/lib/i18n/chunks/de-5.ts
Removed settings.mascot.customGif* entries and replaced with new mascot, developer menu, appearance, and common UI localization strings for migration, onboarding, progress, workspace, calls, rewards, and channel contexts.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • tinyhumansai/openhuman#2522: Modifies the same German i18n file de-5.ts around the settings.mascot.customGif* keys (inverse operations on these translation entries).

Suggested labels

working

Poem

🐰 Fluffy hops through translation files so neat,
Old mascot GIFs are swept off their feet,
New German phrases bloom and grow,
From settings to channels, the translations flow,
A little hop here, a reword there—
Localization magic fills the air!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change—removing duplicate German mascot GIF keys—and directly addresses the core issue (TypeScript TS1117 errors) that the PR resolves.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot added the working A PR that is being worked on by the team. label May 25, 2026
@senamakel senamakel merged commit 36fe567 into tinyhumansai:main May 25, 2026
30 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

working A PR that is being worked on by the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants