Conversation
…on, add Recovery Phrase settings panel - Remove "Open Accessibility" button from ScreenPermissionsStep (step 2) - Remove MnemonicStep (step 5) from onboarding, reducing total steps from 6 to 5 - Move onboarding completion logic (setOnboardedForUser + setOnboardingCompleted) into handleSkillsNext - Add RecoveryPhrasePanel in Settings with the same BIP39 generate/import functionality - Wire recovery-phrase route into Settings.tsx, SettingsHome menu, and useSettingsNavigation
…nd dictation routes)
… selector Address CodeRabbit review feedback: - Add aria-label to each recovery phrase word input for screen readers - Add word-count selector (12/15/18/21/24) so longer phrases can be entered manually, not just via paste
…ipboard fallback
Address CodeRabbit round 2:
- Remove auto-focus-advance after single character input (was breaking
manual word entry — typing 'abandon' would split across slots)
- Guard execCommand('copy') fallback with return value check
…g stale ACL builds Add cargo:rerun-if-changed directives for permissions/ and capabilities/ directories in build.rs so Tauri regenerates ACL tables on incremental builds. Also add missing permission entries for dictation hotkey commands. Closes #270
…ess-command-not-found
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThis PR fixes a bug where the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Summary
cargo:rerun-if-changeddirectives forpermissions/andcapabilities/directories inapp/src-tauri/build.rsso Tauri regenerates ACL tables on incremental buildsregister_dictation_hotkeyandunregister_dictation_hotkeyinallow-core-process.tomlProblem
Clicking "Restart & Refresh Permissions" on the onboarding Screen & Accessibility Permissions step showed
Command restart_core_process not foundeven though the command was correctly registered ingenerate_handler!, had a permission TOML, and was referenced in capabilities.Root cause:
build.rshad nocargo:rerun-if-changeddirectives for thepermissions/orcapabilities/directories. When these files were added/changed, cargo's incremental builds skipped re-runningtauri-build, embedding stale ACL tables that didn't include the new permission entries.Changes
app/src-tauri/build.rsrerun-if-changedforpermissionsandcapabilitiesdirsapp/src-tauri/permissions/allow-core-process.tomlregister_dictation_hotkeyandunregister_dictation_hotkeyTest plan
cargo clean+yarn tauri dev) — verify "Restart & Refresh Permissions" works on ScreenPermissionsStepCloses #270
Summary by CodeRabbit
Bug Fixes
New Features