Skip to content

test(e2e): update composer selectors for new placeholder + voice button#3206

Merged
graycyrus merged 1 commit into
tinyhumansai:mainfrom
graycyrus:fix/composer-e2e-selectors
Jun 2, 2026
Merged

test(e2e): update composer selectors for new placeholder + voice button#3206
graycyrus merged 1 commit into
tinyhumansai:mainfrom
graycyrus:fix/composer-e2e-selectors

Conversation

@graycyrus
Copy link
Copy Markdown
Contributor

@graycyrus graycyrus commented Jun 2, 2026

Summary

Follow-up to #3165 (composer redesign). That PR renamed the composer placeholder (Type a message...How can I help you today?) and the mic-entry button (Start recordingVoice mode), and updated the Vitest tests — but the Playwright + WDIO E2E specs that select by those strings were missed and merged stale.

This updates all 26 affected spec files so the E2E specs match the shipped composer:

  • getByPlaceholder('Type a message...')getByPlaceholder('How can I help you today?')
  • textarea[placeholder="Type a message..."] selector + harness docstring
  • marker-array / textExists / waitForAnyText references
  • mic-entry button: Start recordingVoice mode (MicComposer's own record button stays Start recording)

Test plan

  • No stale Type a message references remain in app/test/
  • All 26 spec files reference the shipped placeholder
  • pnpm typecheck — clean
  • pnpm format:check — clean
  • N/A: No app/Rust changes — test-only follow-up

Refs #3165

Summary by CodeRabbit

Release Notes

  • Tests
    • Updated test selectors across end-to-end and integration test suites to reflect changes to the chat input placeholder text.

The composer redesign renamed the placeholder ("Type a message..." ->
"How can I help you today?") and the mic-entry button ("Start recording"
-> "Voice mode"). Update all Playwright + WDIO specs that select by
these strings. MicComposer's own record button keeps "Start recording".

Fixes failing E2E lanes 1/2/4.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 2, 2026

Review Change Stack

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

This PR updates test selectors across the E2E and Playwright test suites to match a chat composer UI redesign. The core selector constant in the shared harness helper is updated first, followed by widespread updates to all test specs to use the new placeholder text "How can I help you today?" instead of "Type a message...".

Changes

Chat Composer Placeholder Migration

Layer / File(s) Summary
Harness helper baseline
app/test/e2e/helpers/chat-harness.ts
The shared COMPOSER_SELECTOR constant and its documentation are updated to locate the textarea via the new placeholder text, which affects all E2E tests that use typeIntoComposer or clickSend.
E2E test specs update
app/test/e2e/specs/chat-harness-cancel.spec.ts, app/test/e2e/specs/chat-harness-send-stream.spec.ts, app/test/e2e/specs/chat-tool-error-recovery.spec.ts, app/test/e2e/specs/composio-github-tools-tags.spec.ts, app/test/e2e/specs/conversations-web-channel-flow.spec.ts, app/test/e2e/specs/harness-composio-tool-flow.spec.ts, app/test/e2e/specs/skill-multi-round.spec.ts, app/test/e2e/specs/voice-mode.spec.ts
E2E test files update textarea selectors and UI readiness checks to detect the composer by the new placeholder text across cancel, stream, error recovery, tool flow, navigation, and voice mode scenarios.
Playwright test specs update
app/test/playwright/specs/chat-conversation-history.spec.ts, app/test/playwright/specs/chat-harness-cancel.spec.ts, app/test/playwright/specs/chat-harness-scroll-render.spec.ts, app/test/playwright/specs/chat-harness-send-stream.spec.ts, app/test/playwright/specs/chat-harness-subagent.spec.ts, app/test/playwright/specs/chat-harness-wallet-flow.spec.ts, app/test/playwright/specs/chat-multi-tool-round.spec.ts, app/test/playwright/specs/chat-tool-call-flow.spec.ts, app/test/playwright/specs/chat-tool-error-recovery.spec.ts, app/test/playwright/specs/conversations-web-channel-flow.spec.ts, app/test/playwright/specs/harness-channel-bridge-flow.spec.ts, app/test/playwright/specs/harness-composio-tool-flow.spec.ts, app/test/playwright/specs/harness-cron-prompt-flow.spec.ts, app/test/playwright/specs/harness-search-tool-flow.spec.ts, app/test/playwright/specs/skill-multi-round.spec.ts, app/test/playwright/specs/user-journey-full-task.spec.ts, app/test/playwright/specs/voice-mode.spec.ts
Playwright test files update all sendMessage helpers and UI readiness assertions to target the chat input using the new placeholder text across conversation, tool flow, error recovery, channel, and voice mode tests.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~4 minutes

Possibly related PRs

  • tinyhumansai/openhuman#3165: The main PR's test updates to locate the chat composer textarea by the new placeholder ("How can I help you today?") are directly driven by the composer redesign in #3165 that changed the composer's placeholder/UI.
  • tinyhumansai/openhuman#2353: Both PRs touch the chat-harness composer typing/sending flow in app/test/e2e/helpers/chat-harness.ts—the main PR changes the textarea locator via the placeholder, while the retrieved PR refactors the composer/send helpers (and adds socket-connected waiting)—so they're code-level related to the same interaction code.

Suggested labels

working

Suggested reviewers

  • sanil-23

Poem

🐰 Selectors dance in the test parade,
"How can I help you?" the new cascade,
From type to talk, the placeholders sway,
Thirty specs updated—hooray, hooray! 🎉

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 14.29% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely summarizes the main change: updating test selectors to match new composer placeholder text and voice button label changes from the redesign.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@graycyrus graycyrus marked this pull request as ready for review June 2, 2026 10:55
@graycyrus graycyrus requested a review from a team June 2, 2026 10:55
@coderabbitai coderabbitai Bot added the working A PR that is being worked on by the team. label Jun 2, 2026
@graycyrus graycyrus merged commit cac09cb into tinyhumansai:main Jun 2, 2026
22 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

working A PR that is being worked on by the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant