feat: split screen intelligence from accessibility and add dedicated settings#50
Merged
Merged
Conversation
- Reformatted code in `core_server.rs` for better readability, including consistent indentation and line breaks. - Enhanced the clarity of function calls and JSON handling by spreading parameters across multiple lines. - Improved overall structure and maintainability of the dispatch and settings view response functions.
…IntelligenceConfig - Renamed AccessibilityAutomationConfig to ScreenIntelligenceConfig across the codebase for improved clarity. - Updated related structures and functions to utilize the new configuration, including default values and additional fields for enhanced functionality. - Ensured backward compatibility by adjusting references in the AccessibilityEngine and related modules. - Enhanced the AppContext structure to include window bounds, improving state management for UI components.
… functionality - Added a new Screen Intelligence module to manage window capture policies, vision summaries, and memory ingestion. - Implemented settings for enabling/disabling features, configuring capture policies, and managing allowlists/deny lists. - Updated the accessibility panel to include Screen Intelligence options and integrated permission requests for screen recording and accessibility. - Enhanced the core server to handle updates to Screen Intelligence settings and ensure proper state management across the application. - Refactored related components and Redux state management to support the new features, improving user experience and functionality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
screen_intelligenceas a first-class feature area while preserving existingopenhuman.accessibility_*RPC compatibility.openhuman/screen_intelligence, withopenhuman/accessibilityas a compatibility re-export.openhuman.update_screen_intelligence_settings) and config fields for policy mode and allowlist/denylist behavior.Screen Intelligencepanel/route.screen_intelligencecategory.Problem
Solution
openhuman::screen_intelligencemodule and moved implementation ownership there.openhuman::accessibilityand leavingopenhuman.accessibility_*RPC methods in place.openhuman.update_screen_intelligence_settingsto persist and apply runtime config updates.all_except_blacklist/whitelist_only) with allowlist + denylist matching.Testing
yarn -s compilecargo check --manifest-path src-tauri/Cargo.tomlnpx prettier --check .,npx eslint .,npx tsc --noEmit,cargo fmt --manifest-path src-tauri/Cargo.toml,cargo check --manifest-path src-tauri/Cargo.tomlImpact
screen_intelligencememory category.Breaking Changes
Related