feat(privacy): backend-backed capability privacy metadata + PrivacyPanel#760
Merged
senamakel merged 2 commits intoApr 22, 2026
Merged
Conversation
Adds optional `CapabilityPrivacy { leaves_device, data_kind, destinations }`
to the about_app capability catalog so the in-app Privacy surface can be
backend-backed instead of hand-maintained. Twelve representative capabilities
are annotated for the first audited set (raw/local, derived/backend,
credentials, diagnostics, model download); remaining entries default to
None and are simply not surfaced. Wire format stays backward compatible
via skip_serializing_if.
Replaces the hand-maintained privacy rows with data fetched from openhuman.about_app_list. Only capabilities that ship privacy metadata are rendered; loading and RPC failure both degrade gracefully and the analytics toggle plus explanatory copy remain intact. Adds a small typed client (utils/tauriCommands/aboutApp.ts) and focused vitest coverage for render, omission of unannotated entries, and RPC failure.
Contributor
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 31 minutes and 40 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (7)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
4 tasks
senamakel
added a commit
to jwalin-shah/openhuman
that referenced
this pull request
Apr 22, 2026
… WelcomeStep test - Rebase onto upstream/main (20 commits since PR merge base) - Resolve PrivacyPanel.tsx conflict: keep upstream capability-backed dynamic privacy list (PR tinyhumansai#760) rather than the static whatLeavesItems fallback — the dynamic system supersedes the static one - Resolve WelcomeStep.tsx conflict: keep simplified interface from upstream (nextDisabled/nextLoading/nextLoadingLabel removed) plus WhatLeavesLink footer from this PR - Resolve login-flow.spec.ts conflict: remove ReferralApplyStep comment (step was removed in upstream PR tinyhumansai#772), keep ContextGatheringStep user-driven gate copy from this PR - Fix WelcomeStep.test.tsx: remove test that passes now-removed props (nextDisabled, nextLoading, nextLoadingLabel) — update to verify CTA is always enabled in simplified interface - Apply Prettier formatting across files reformatted post-rebase - All quality checks pass: typecheck clean, lint 0 errors, format unchanged, 534 unit tests passed (2 pre-existing skips)
3 tasks
This was referenced May 14, 2026
AusAgentSmith
pushed a commit
to AusAgentSmith/openhuman
that referenced
this pull request
May 23, 2026
…nel (tinyhumansai#760) * feat(about_app): add capability privacy metadata Adds optional `CapabilityPrivacy { leaves_device, data_kind, destinations }` to the about_app capability catalog so the in-app Privacy surface can be backend-backed instead of hand-maintained. Twelve representative capabilities are annotated for the first audited set (raw/local, derived/backend, credentials, diagnostics, model download); remaining entries default to None and are simply not surfaced. Wire format stays backward compatible via skip_serializing_if. * feat(settings): drive privacy panel from about_app capabilities Replaces the hand-maintained privacy rows with data fetched from openhuman.about_app_list. Only capabilities that ship privacy metadata are rendered; loading and RPC failure both degrade gracefully and the analytics toggle plus explanatory copy remain intact. Adds a small typed client (utils/tauriCommands/aboutApp.ts) and focused vitest coverage for render, omission of unannotated entries, and RPC failure. --------- Co-authored-by: Jwalin Shah <jshah1331@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
about_appcapabilities can now shipCapabilityPrivacy { leaves_device, data_kind, destinations }. Twelve representative capabilities are annotated for the first audited set (raw/local, derived/backend, credentials, diagnostics, model download).PrivacyPanelno longer hand-maintains the rows — it callsopenhuman.about_app_listand renders only entries that disclose privacy metadata. Analytics toggle and explanatory copy are unchanged.privacyis omitted whenNone.Why
Privacy disclosure was duplicated as static UI strings. Anchoring it to the capability catalog makes "what leaves my computer" a property of the feature itself, not of the panel that happens to render it. That keeps the disclosure honest as features ship.
Notes
Test plan