Decode/Unmarshal a msgpack array of arbitrary length into a struct (new directive:vartuple) #399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klauspost
approved these changes
Aug 10, 2025
Collaborator
klauspost
left a comment
klauspost
left a comment
There was a problem hiding this comment.
ok. I think I get it now. It allows...
- Adding more fields (at the end) and it will remain readable by older versions.
- Skipping serializing fields that have the zero value at the end of objects.
- Removing fields at the end.
lgtm
Collaborator
|
Also 2 PRs in 10 minutes... what is happening :) |
UladzimirTrehubenka
force-pushed
the
vartuple
branch
from
5873e2f to
b20ba32
Compare
…ew directive:vartuple)
UladzimirTrehubenka
force-pushed
the
vartuple
branch
from
b20ba32 to
18f1f35
Compare
UladzimirTrehubenka
force-pushed
the
vartuple
branch
from
50c544a to
8a6e8c2
Compare
philhofer
approved these changes
Aug 11, 2025
Contributor
Author
|
@philhofer @klauspost thx, any plans to merge into master? |
This was referenced Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#275 implementation, #395 fix
@klauspost added vartuple section.