Skip to content

DOC-2222: Fix broken mergetags in demos, warnings and errors #3015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MitchC1999 merged 5 commits into from
Nov 30, 2023
Merged

DOC-2222: Fix broken mergetags in demos, warnings and errors #3015

MitchC1999 merged 5 commits into from
Nov 30, 2023

Conversation

@MitchC1999
Copy link
Contributor

@MitchC1999 MitchC1999 commented Nov 29, 2023 •
edited by kemister85
Loading

Ticket: DOC-2222

Changes:

  • Fixed missing content wrapped in double curly brackets
  • Fixed all current warnings and errors in local builds

Pre-checks:

  • Branch prefixed with feature/6/ or hotfix/6/
  • Changelog entry added
  • modules/ROOT/nav.adoc has been updated (if applicable)
  • Files has been included where required (if applicable)
  • Files removed have been deleted, not just excluded from the build (if applicable)
  • (New product features only) Release Note added

Review:

  • Documentation Team Lead has reviewed

@MitchC1999 MitchC1999 requested a review from a team as a code owner November 29, 2023 02:28
tiny-ben-tran
tiny-ben-tran reviewed Nov 29, 2023
View reviewed changes
kemister85
kemister85 approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@kemister85 kemister85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MitchC1999 LGTM Nice work thank you for fixing this issue.

@MitchC1999 MitchC1999 merged commit 413502b into release/docs-6 Nov 30, 2023
@MitchC1999 MitchC1999 deleted the hotfix/6/DOC-2222 branch November 30, 2023 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kemister85 kemister85 kemister85 approved these changes

@tiny-ben-tran tiny-ben-tran tiny-ben-tran approved these changes

@Afraithe Afraithe Awaiting requested review from Afraithe Afraithe was automatically assigned from tinymce/documentation-team

@ShiridiGandham ShiridiGandham Awaiting requested review from ShiridiGandham ShiridiGandham was automatically assigned from tinymce/documentation-team

@TheSpyder TheSpyder Awaiting requested review from TheSpyder

@ArvinJ-H ArvinJ-H Awaiting requested review from ArvinJ-H

@ltrouton ltrouton Awaiting requested review from ltrouton

@mkzhx mkzhx Awaiting requested review from mkzhx

@shanmen-tiny shanmen-tiny Awaiting requested review from shanmen-tiny

@danoaky-tiny danoaky-tiny Awaiting requested review from danoaky-tiny

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MitchC1999 @kemister85 @tiny-ben-tran