TINY-4531: Long dropdown menu items will no longer misplace the entry.#10915
Merged
TINY-4531: Long dropdown menu items will no longer misplace the entry.#10915
Conversation
WalkthroughThis pull request fixes a positioning bug in dropdown menus with Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@modules/alloy/src/test/ts/browser/ui/dropdown/DropdownListMatchWidthTest.ts`:
- Line 95: The test description string in the it(...) call inside
DropdownListMatchWidthTest (the test named starting "TINY-4531: The dropdown
menu should be placed properly on the left side of the") is truncated; update
the description to a complete sentence such as "TINY-4531: The dropdown menu
should be placed properly on the left side of the dropdown trigger" (or another
accurate target like "input") so the test name clearly states its expectation;
edit the it(...) description in DropdownListMatchWidthTest.ts accordingly.
modules/alloy/src/test/ts/browser/ui/dropdown/DropdownListMatchWidthTest.ts
Show resolved
Hide resolved
spocke
approved these changes
Feb 23, 2026
MitchC1999
approved these changes
Feb 24, 2026
HAFRMO
added a commit
that referenced
this pull request
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Ticket: TINY-4531
Description of Changes:
If we change the size of a dropdown component, re-place it on the screen to prevent an issue where very wide content would match it to window size and place it on the far left before the resizing could take affect
Pre-checks:
feature/,hotfix/orspike/Review:
GitHub issues (if applicable):
Summary by CodeRabbit