Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new nettools sensor crate to Omnitrace for polling hostname and routing-table state and emitting structured change events via the existing callback hub.
Changes:
- Introduces
nettoolscrate withNetToolssensor, backends, andNetToolsEvent/mask types. - Adds demo binaries for hostname, routes, and default-route monitoring plus README docs.
- Adds async unit tests validating emitted events using deterministic sequence backends.
Reviewed changes
Copilot reviewed 7 out of 12 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/callbacks.rs | Minor formatting adjustments in CallbackHub implementation. |
| nettools/src/lib.rs | Implements NetTools sensor, live backends (hostname + route polling), and change detection logic. |
| nettools/src/events.rs | Adds event and mask definitions for nettools. |
| nettools/src/nettools_ut.rs | Adds async unit tests for hostname/route/default-route events. |
| nettools/src/bin/nettools-hostchange.rs | Demo binary emitting hostname change events. |
| nettools/src/bin/nettools-routes.rs | Demo binary emitting route add/remove/change events. |
| nettools/src/bin/nettools-default-route.rs | Demo binary emitting default-route add/remove/change events. |
| nettools/src/bin/README.md | Usage docs for demo binaries. |
| nettools/README.md | Crate-level overview and example commands. |
| nettools/Cargo.toml | Declares the new crate and its bins/dependencies. |
| Cargo.toml | Adds nettools to workspace members. |
| Cargo.lock | Adds lockfile entries for the new crate. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nettools are various networking tools to detect changes, such as default route, routing table, hostname etc.