Skip to content

Conversation

@mwanji
Copy link
Contributor

@mwanji mwanji commented Apr 30, 2018

Addresses problem raised in #102

Let me know if there are any style / testing issues with this PR.

@tipsy
Copy link
Owner

tipsy commented Apr 30, 2018

Thanks @mwanji, I had a look at this fix a long time ago, this is what I had locally: #114. My fix is a little broken, ideally we shouldn't render "empty space" for the each tag. Maybe you can improve it?

@mwanji
Copy link
Contributor Author

mwanji commented May 1, 2018

@tipsy I integrated your changes from #114 piecemeal here, as it was easier for me to understand it that way. The main difference is that the extra space and level of indentation have been removed from the RenderFormattedText::testFormattedTags_each unit test expectation.

I also replaced ImmutableList::of with Arrays::asList, to be able to remove Google Guava from the dependencies.

@tipsy
Copy link
Owner

tipsy commented May 1, 2018

Thanks, looks great!

@tipsy
Copy link
Owner

tipsy commented May 1, 2018

This has been released in 1.3.0 now.

@mwanji
Copy link
Contributor Author

mwanji commented May 1, 2018

Cool, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants