Fix bugs and increase test coverage to 91%#6
Merged
tirthpatell merged 4 commits intomainfrom Mar 15, 2026
Merged
Conversation
…s' (#1) from fix-and-feat/viewer-editor-linter into main Reviewed-on: https://git.awswho.com/tirth/mdr/pulls/1
…se test coverage Fix editor Left/Right arrow keys not calling scrollToCursor() when wrapping across lines, causing the cursor to go off-screen. Fix viewer search backspace corrupting multi-byte Unicode characters by using rune-based truncation. Remove dead code in NewBuffer. Add 41 new tests covering edge cases, boundary conditions, and previously untested code paths. Coverage: 74.2% -> 91.3%.
Repository owner
deleted a comment from
codecov-commenter
Mar 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scrollToCursor()when wrapping across lines, preventing the cursor from going off-screenlen(lines) == 0check inNewBuffer(strings.Split always returns ≥1 element)Coverage
internal/editorinternal/viewerinternal/markdowninternal/linterinternal/statsTest plan
-raceflaggo fmt ./...cleango vet ./...cleango tool cover -func