fix(openai): support max_completion_tokens for reasoning models#80
Merged
maxchang3 merged 2 commits intodev/releasefrom Apr 11, 2026
Merged
fix(openai): support max_completion_tokens for reasoning models#80maxchang3 merged 2 commits intodev/releasefrom
max_completion_tokens for reasoning models#80maxchang3 merged 2 commits intodev/releasefrom
Conversation
max_completion_tokens for reasoning models
max_completion_tokens for reasoning modelsmax_completion_tokens for reasoning models
Collaborator
Author
|
For this PR, please use Squash and merge |
Collaborator
Author
|
Although current models seem to only accept |
maxchang3
added a commit
that referenced
this pull request
Apr 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes raycast/extensions#26761
Background
According to the OpenAI docs, reasoning models (e.g.
o1,o3,gpt-5) requiremax_completion_tokens, andmax_tokensis not supported:Currently, our extension uses
max_tokensfor all models, which leads to incompatibility with reasoning models.For OpenAI-compatible providers, behavior is inconsistent:
max_tokensmax_completion_tokens)This creates ambiguity when integrating with different providers.
Changes
Introduced model-based detection for reasoning models using pattern (From Dify’s approach):
/^(o1|o3|gpt-5)/iAdded endpoint-aware logic:
https://api.openai.com/)max_completion_tokensAdded a user-configurable option:
forceMaxCompletionTokensmax_completion_tokensregardless of endpoint/model