[stack-switching] Unboxed continuation build option #547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
titzer
reviewed
Jan 6, 2026
Owner
titzer
left a comment
titzer
left a comment
There was a problem hiding this comment.
Awesome, with only the minor-est of comments :)
|
|
||
| CONTINUATION="src/engine/continuation/BoxedContinuation.v3" | ||
| CONTINUATION="src/engine/continuation/UnboxedContinuation.v3" | ||
| CONTINUATION_X86_64="src/engine/continuation/X86_64UnboxedContinuation.v3" |
Owner
There was a problem hiding this comment.
Let's put this in src/engine/x86-64/
Contributor
Author
There was a problem hiding this comment.
I think everything under /x86-64/* is included unconditionally in the x86-64 target, but which continuation offset file to include is dependent on whether --boxed-continuation is enabled. Can this still be done if both offset files are moved under /x86-64/?
Owner
There was a problem hiding this comment.
You could create a further subdirectory perhaps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces an unboxed stack-switching implementation that avoids heap allocation when creating continuations via
suspend/switch. This behavior can be configured at build-time: the build defaults to the unboxed mode, and the boxed implementation can be enabled by passing--boxed-continuationtobuild.sh.