Skip to content

Add prettier to pre-commit#36

Merged
krishnans2006 merged 2 commits into
tjcsl:masterfrom
JasonGrace2282:eslint
Jun 1, 2024
Merged

Add prettier to pre-commit#36
krishnans2006 merged 2 commits into
tjcsl:masterfrom
JasonGrace2282:eslint

Conversation

@JasonGrace2282
Copy link
Copy Markdown
Member

Basically format JS/CSS

@JasonGrace2282 JasonGrace2282 requested a review from a team as a code owner May 28, 2024 02:37
Copy link
Copy Markdown
Member

@krishnans2006 krishnans2006 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing - LGTM!

I think we can ignore the fact that most of these style issues originated from my code...

@krishnans2006
Copy link
Copy Markdown
Member

I'd like to merge this PR with a rebase (or fast-forward) merge, since it's useful to differentiate the two commits.

Could you update your commit messages to better reflect what they accomplish? (e.g. "Add prettier config and CI" or "Add autofixed changes from prettier")?

@JasonGrace2282
Copy link
Copy Markdown
Member Author

Consider it done :)

@krishnans2006 krishnans2006 merged commit 700b223 into tjcsl:master Jun 1, 2024
@JasonGrace2282 JasonGrace2282 deleted the eslint branch June 1, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants