fix being able to see submissions after course is archived#53
Merged
Conversation
Also includes a test
JasonGrace2282
force-pushed
the
fix-submission
branch
from
9d3e1ff to
8ca7979
Compare
krishnans2006
requested changes
Jun 29, 2024
Member
krishnans2006
left a comment
krishnans2006
left a comment
There was a problem hiding this comment.
LGTM, but here's a quick change that you should consider adding to this PR:
krishnans2006
approved these changes
Jun 29, 2024
Member
krishnans2006
left a comment
krishnans2006
left a comment
There was a problem hiding this comment.
Nice work!
In the future, we might want to consider simplifying the somewhat hard-to-read query statements in QuerySets, but I don't know how we would go about that at the moment.
krishnans2006
force-pushed
the
master
branch
2 times, most recently
from
305ca99 to
ad43913
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I should add a test for this shouldn't I 🤔 (EDIT: done)