Misc fixes for client.py

[cdce8p]

• Fix typing: Replace any (the function) with typing.Any
• Remove OrderedDict: for newer Python (>=3.7) versions the insertion order into dicts is already kept
• Move default arguments for hourly_start and hourly_end into the function body. Otherwise they are executed when the the class is initialized. I.e. those arguments would stay the same for new method calls.
• Replace datetime.utcnow with the timezone aware datetime.now(tz=UTC).
  utcnow will be deprecated with Python 3.12.

I wasn't sure about the + "Z" which you added manually to the iso datetime. Could you check which format the API expects? datetime.isoformat would return YYYY-MM-DDTHH:MM:SS.ffffff+HH:MM.
https://docs.python.org/3/library/datetime.html#datetime.datetime.isoformat

[tjhorner]

I wasn't sure about the + "Z" which you added manually to the iso datetime. Could you check which format the API expects? datetime.isoformat would return YYYY-MM-DDTHH:MM:SS.ffffff+HH:MM.

Passing a date in that format (I used 2023-09-14T16:09:38.522987+00:00) results in a 400 from the API. Passing the same date in the previous format (2023-09-14T16:09:38.522987Z) works fine. The documentation never explicitly mentions a date format to use (the scalar type is just date-time and there is no description of this type anywhere), but the responses all use UTC dates in the format YYYY-MM-DDTHH:MM:SSZ.

[cdce8p]

Passing a date in that format (I used 2023-09-14T16:09:38.522987+00:00) results in a 400 from the API. Passing the same date in the previous format (2023-09-14T16:09:38.522987Z) works fine. The documentation never explicitly mentions a date format to use (the scalar type is just date-time and there is no description of this type anywhere), but the responses all use UTC dates in the format YYYY-MM-DDTHH:MM:SSZ.

Added some logic to convert the datetime arguments to UTC (if they aren't already) and to remove the timezone afterwards. Note that it will only convert to UTC if the datetime was passed with a timezone, otherwise it would assume UTC. Does this make sense?

[tjhorner]

Sounds good to me.

[tjhorner]

Released this as 1.0.3.

@cdce8p Do you anticipate making any more PRs soon? If not, I will go ahead and create the PR to bump the version in HA core.

[cdce8p]

@cdce8p Do you anticipate making any more PRs soon? If not, I will go ahead and create the PR to bump the version in HA core.

No 😉
Just saw the DeprecationWarning in Home Assistant and wanted to fix it. I've already started testing Python 3.12 on my fork.

[tjhorner]

Great, thanks! I'm not too familiar with Python and its ecosystem/idiosyncrasies so I appreciate you catching and fixing these.