fix: support macOS in capture privilege check#1
Merged
Conversation
`socket.AF_PACKET` is Linux-only and raises `AttributeError` on macOS. Use a platform-aware approach: check UID for root, try AF_PACKET on Linux, and fall back to BPF device access on macOS/BSD.
Owner
|
Great Observation! I have not tested leetha on MacOS and there should be no regression to break any Linux changes. Pull request has been approved. Thank you for your contributions to the project! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_has_capture_privilege()incli.pyusessocket.AF_PACKETwhich is Linux-only and raisesAttributeErroron macOSos.getuid() == 0first (works on both Linux and macOS)AF_PACKETraw socket on Linux/dev/bpf*device access on macOS/BSDReproduce
On macOS:
Before fix:
After fix: starts normally.
Test plan
leethastarts and captures packets