implement fully async reaper #583
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turnalek
commented
Sep 17, 2025
| let contents = std::fs::read(PIVOT_OK2_SUCCESS_FILE).unwrap(); | ||
| assert_eq!(std::str::from_utf8(&contents).unwrap(), msg); | ||
|
|
||
| let enclave_info_url = |
Contributor
Author
There was a problem hiding this comment.
NOTE: this was working by accident before, the timing "just worked" but if the pivot exited and the enclave exited (becuase it's set to not restart the pivot) this call would fail.
Turnalek
force-pushed
the
ales/async_reaper
branch
from
7df174d to
f0aacf7
Compare
emostov
reviewed
Sep 18, 2025
emostov
reviewed
Sep 18, 2025
emostov
reviewed
Sep 18, 2025
emostov
reviewed
Sep 18, 2025
emostov
approved these changes
Sep 18, 2025
Contributor
emostov
left a comment
emostov
left a comment
There was a problem hiding this comment.
Overall looks good. Just one comment that looks out of place and I want to make some of the sleeps shorter but doesn't need to be this PR
Co-authored-by: Zeke Mostov <z.mostov@gmail.com>
emostov
approved these changes
Sep 18, 2025
Contributor
emostov
left a comment
emostov
left a comment
There was a problem hiding this comment.
Nice - new changes look good!
r-n-o
approved these changes
Sep 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation (Problem vs. Solution)
Refactor qos_core
Reaperto use async tokio spawning directly without threads to lower unnecessary load.Also fixes a bunch of tests with forgotten
std::thread::sleepwhich shouldn't be used with tokio as it blocks the main task.How I Tested These Changes
Tested on preprod by deploying from this PR with a temporary mono PR.